[elfutils] Add libdebuginfod feature#26107
Closed
BigRedEye wants to merge 3 commits into
Closed
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Adela0814
added
the
category:port-feature
Adela0814
suggested changes
Aug 2, 2022
Adela0814
approved these changes
Aug 2, 2022
Adela0814
added
info:needs-maintainer-attention
BillyONeal
reviewed
Aug 5, 2022
| vcpkg_install_make() | ||
| file(REMOVE "${CURRENT_PACKAGES_DIR}/debug/lib/pkgconfig/libdebuginfod.pc" "${CURRENT_PACKAGES_DIR}/lib/pkgconfig/libdebuginfod.pc") #--disable-debuginfod | ||
| file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/etc/debuginfod" "${CURRENT_PACKAGES_DIR}/etc/debuginfod") | ||
| if (WITH_LIBDEBUGINFOD) |
Member
There was a problem hiding this comment.
This seems like it can't be correct: Why are you deleting the bits backing the feature if the feature is on? (Is the sense of this if flipped?)
BillyONeal
reviewed
Aug 5, 2022
| PATCHES configure.ac.patch | ||
| PATCHES | ||
| configure.ac.patch | ||
| install-libdebuginfod.patch |
Member
There was a problem hiding this comment.
Can you explain in detail what this patch is doing?
Has it been submitted upstream?
BillyONeal
added
requires:author-response
and removed
info:needs-maintainer-attention
Contributor
|
Convert this PR to draft since there is no progress. Please ping us if this PR is ready for review again. |
Contributor
|
Closing this PR since it seems that no progress is being made. Please ping us to reopen if work is still being done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does your PR fix?
Allows to use libdebuginfod from elfutils
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes