[physx] Add support for Mac on ARM. #25154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Darryl Pogue <darryl@dpogue.ca> Co-authored-by: Niklas Gray <niklas@ourmachinery.com>
Contributor
Author
|
CC @dpogue, @colincornaby |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Hoikas
changed the title
LilyWangLL
added
category:port-feature
LilyWangLL
approved these changes
Jun 9, 2022
LilyWangLL
added
the
info:needs-maintainer-attention
Thomas1664
reviewed
Jun 9, 2022
ras0219-msft
requested changes
Jun 10, 2022
Contributor
ras0219-msft
left a comment
ras0219-msft
left a comment
There was a problem hiding this comment.
Thanks for the PR!
I was able to greatly reduce the size of the werror patch while also fetching the PR diffs from GitHub.
I pushed my changes to a branch, could you please pull it into this PR?
git fetch https://github.com/ras0219-msft/vcpkg physx-mac-arm
git merge FETCH_HEAD
Contributor
Author
|
Pulled, thanks for the improvement |
LilyWangLL
added
the
info:needs-maintainer-attention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests ports the patch from NVIDIAGameWorks/PhysX#569 to fix the physx port build for Mac on ARM (aka "Silicon"). Unfortunately, we cannot simply download the patch from the PR itself due to the PR patch conflicting with our own
remove-werror.patch.What does your PR fix?
See above
Which triplets are supported/not supported? Have you updated the CI baseline?
Add support for community triplet arm64-osx.
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/