-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wxwidgets] Fix find dependency pcre2 #24874
Conversation
For x64-linux, the config tool ( |
It must be a regression. Before this PR, |
The value
|
@dg0yt
Seems like this problem is hard to fix at the moment? |
If pcre2 is properly referenced in Everything else is unrelated:
|
The default toolkits which we can pick is: elseif(UNIX)
set(wxDEFAULT_TOOLKIT gtk3)
set(wxTOOLKIT_OPTIONS gtk2 gtk3 gtk4 motif qt)
set(wxPLATFORM UNIX) We can use qt but it will take more and more build time. |
I know. Qt might be a future feature... but it is pointless: Why use a cross-platform framework on top of another cross-platform framework? I think that developers expect the default, which is gtk3 for Linux. |
I notice that gtk4 is on that list -- progress! |
This LGTM though, thanks! |
It is on the list, but it simply won't work soon - not even with wxWidgets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, only the release version of the dependency pcre2 is found during the configuration of wxwidgets, fix this.
Fixes #24851.