[python3] Add feature deprecated-win7-support.#16420
Merged
vicroms merged 6 commits intomicrosoft:masterfrom Mar 29, 2021
Merged
[python3] Add feature deprecated-win7-support.#16420vicroms merged 6 commits intomicrosoft:masterfrom
vicroms merged 6 commits intomicrosoft:masterfrom
Conversation
This prevents potential patch application conflicts.
This backports the fix for bpo-39401 from the Python 3.8 branch instead of the one from the Python 3.9 branch, which dropped support for Windows 7.
Hoikas
changed the title
NancyLi1013
added
the
category:port-feature
NancyLi1013
approved these changes
Feb 26, 2021
NancyLi1013
added
requires:discussion
info:needs-maintainer-attention
ras0219-msft
approved these changes
Mar 2, 2021
Contributor
ras0219-msft
left a comment
ras0219-msft
left a comment
There was a problem hiding this comment.
I reverted changes to the intermediate patch files which were otherwise unaffected -- other than that this LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PSF has a policy for dropping support for any Microsoft OS that is beyond end of support. As of Python 3.,9, Windows 7 support was dropped, preventing use the of the python3 port on any Windows 7 machine. The support drop was relatively soft, so this feature restores support for Windows 7 behind and off-by-default feature. The included patch forward-ports the fix for bpo-39401 from the Python 3.8 branch due to the Python 3.9 version requiring Windows 8. See python/cpython#18234 whose content is included in the
0007-restores-support-for-windows-7.patch, replacing the content of python/cpython#18231.cc @ras0219-msft re discussion about this in discord last week.