Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[freetds] Remove patches and update to a version that no longer needs them #14529

Merged
merged 3 commits into from
Nov 30, 2020

Conversation

BillyONeal
Copy link
Member

Upstream seems to have version numbered releases but they aren't explicitly numbered well in GitHub, so I've intentionally changed the version-string to something unorderable for now.

… them

Upstream seems to have version numbered releases but they aren't explicitly numbered well in GitHub, so I've intentionally changed the version-string to something unorderable for now.
@BillyONeal BillyONeal added info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Nov 11, 2020
@NancyLi1013 NancyLi1013 self-assigned this Nov 12, 2020
@NancyLi1013
Copy link
Contributor

The hash value seems not correct.

Starting package 2/2: freetds:x86-windows
Building package freetds[core,openssl]:x86-windows...
Could not locate cached archive: W:\eb\eb83eef515d3c211be44328d6f11fc898e8bdc97.zip
-- Downloading https://github.com/freetds/freetds/archive/d33674659aa7d70cf713c8920850c4d6751dbd95.tar.gz...
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:103 (message):
  

  File does not have expected hash:

          File path: [ D:/downloads/temp/freetds-freetds-d33674659aa7d70cf713c8920850c4d6751dbd95.tar.gz ]
      Expected hash: [ a01f3bb0b61459e97e50e0ed6ac0f7b2f17efa18 ]
        Actual hash: [ 1df12fea36f38a8ec3f6509ce72781a82304c8444358e4eb907a1a01a5a254419b2e7ce7d24ae94e961f0725317f6e57f664a7c474c1a89e0f0de71124b0f88d ]

  The file may have been corrupted in transit.  This can be caused by
  proxies.  If you use a proxy, please set the HTTPS_PROXY and HTTP_PROXY
  environment variables to
  "https://user:***@your-proxy-ip-address:port/".

@freddy77
Copy link
Contributor

Hi, please use commit 16f7a6280c7a19bfe5c60e5d61cc08e3f2dff991 instead, see FreeTDS/freetds@16f7a62. This is version 1.2.11. The commit you used is from master branch which is supposed to be development branch, not production one. You can also download the packaged file from https://www.freetds.org (like ftp://ftp.freetds.org/pub/freetds/stable/freetds-1.2.11.tar.gz).

@NancyLi1013
Copy link
Contributor

@freddy77

Thanks for your kindly reminder.

@BillyONeal
Copy link
Member Author

@freddy77 Done, and thanks!

@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Nov 20, 2020
@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed info:reviewed Pull Request changes follow basic guidelines labels Nov 23, 2020
@NancyLi1013
Copy link
Contributor

All checks have passed now.

@strega-nil strega-nil merged commit 9d72e33 into microsoft:master Nov 30, 2020
@strega-nil
Copy link
Contributor

Thanks @BillyONeal !

@BillyONeal BillyONeal deleted the update_freetds branch December 3, 2020 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants