Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use IEnumerable for list parameters in client methods #4787

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Use IEnumerable for list parameters in client methods #4787

wants to merge 3 commits into from

Conversation

JoshLove-msft
Copy link
Contributor

@JoshLove-msft JoshLove-msft commented Oct 17, 2024 •
edited
Loading

Fixes #4786

@microsoft-github-policy-service microsoft-github-policy-service bot added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Oct 17, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 17, 2024 •
edited
Loading

API change check

API changes are not detected in this pull request.

@ArcturusZhang
Copy link
Member

ArcturusZhang commented Oct 18, 2024 •
edited
Loading

do we have something to configure so that we could change this back in azure libraries?
and would this lead to an extra ToList?

@JoshLove-msft
Copy link
Contributor Author

do we have something to configure so that we could change this back in azure libraries? and would this lead to an extra ToList?

Yeah this leads to an extra ToList so I am thinking we need to keep the IList for the serialization ctor.

@JoshLove-msft JoshLove-msft changed the title Use IEnumerable for list parameters Use IEnumerable for list parameters in client methods Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgerangel-msft jorgerangel-msft jorgerangel-msft left review comments

@m-nash m-nash Awaiting requested review from m-nash m-nash is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenAI - Array parameters should be generated as IEnumerable rather than IList
4 participants
@JoshLove-msft @azure-sdk @ArcturusZhang @jorgerangel-msft