-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@typespec/http-specs] Added Spec Summary #4768
base: main
Are you sure you want to change the base?
Conversation
No changes needing a change description found. |
You can try these changes here
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to include that as part of the CI if we want to include it, I am just not sure we still need to include that, but maybe why not
@timotheeguerin I have added the scenario summary to CI. https://dev.azure.com/azure-sdk/public/_build/results?buildId=4244764&view=logs&j=3c0fd1c5-f915-5f9e-1a75-401a79398b8d&t=a73f946c-18d7-5989-79d0-ba3ac014413d Is this ok? |
During the modification of Scenarios in the past weeks, this spec-summary was not added because the scenarios were undergoing modifications. Now, as the migration is complete, this spec summary could be generated.
I have compared the generated file with the file in the
cadl-ranch
summary and confirmed that it is exactly the same except for one change. In thecadl-ranch
repository, thetype/model/templated
scenarios have been removed recently. Those scenarios are still present in thistypespec
repository and part of this spec summary.Please review and approve the PR. Thanks