Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@typespec/http-specs] Added Spec Summary #4768

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

sarangan12
Copy link
Contributor

During the modification of Scenarios in the past weeks, this spec-summary was not added because the scenarios were undergoing modifications. Now, as the migration is complete, this spec summary could be generated.

I have compared the generated file with the file in the cadl-ranch summary and confirmed that it is exactly the same except for one change. In the cadl-ranch repository, the type/model/templated scenarios have been removed recently. Those scenarios are still present in this typespec repository and part of this spec summary.

Please review and approve the PR. Thanks

@azure-sdk
Copy link
Collaborator

No changes needing a change description found.

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

Copy link
Member

@timotheeguerin timotheeguerin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to include that as part of the CI if we want to include it, I am just not sure we still need to include that, but maybe why not

@sarangan12
Copy link
Contributor Author

need to include that as part of the CI if we want to include it, I am just not sure we still need to include that, but maybe why not

@timotheeguerin I have added the scenario summary to CI. https://dev.azure.com/azure-sdk/public/_build/results?buildId=4244764&view=logs&j=3c0fd1c5-f915-5f9e-1a75-401a79398b8d&t=a73f946c-18d7-5989-79d0-ba3ac014413d

Is this ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants