http-client-java, fix bug on POM depencency parse #4561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:java
.../main/java/com/microsoft/typespec/http/client/generator/core/model/projectmodel/Project.java
Outdated
Show resolved
Hide resolved
|
No changes needing a change description found. |
6 tasks
weidongxu-microsoft
changed the title
weidongxu-microsoft
changed the title
|
You can try these changes here
|
weidongxu-microsoft
requested review from
srnagar,
haolingdong-msft and
XiaofeiCao
as code owners
weidongxu-microsoft
requested review from
alzimmermsft,
haolingdong-msft and
XiaofeiCao
and removed request for
srnagar,
haolingdong-msft and
XiaofeiCao
...r-core/src/main/java/com/microsoft/typespec/http/client/generator/core/mapper/PomMapper.java
Show resolved
Hide resolved
haolingdong-msft
approved these changes
Sep 29, 2024
weidongxu-microsoft
deleted the
http-client-java_fix-dependency-merge
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug introduced when refactor.
previous code
https://github.com/Azure/autorest.java/blob/v4.1.36/javagen/src/main/java/com/azure/autorest/model/projectmodel/Project.java#L318-L329
current code missed the "project" node in xpath.