fix the keyCredential issue #4412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
ArcturusZhang
requested review from
m-nash and
JoshLove-msft
as code owners
m-nash
approved these changes
Sep 12, 2024
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
sarangan12
pushed a commit
to sarangan12/typespec
that referenced
this pull request
Sep 16, 2024
Fixes microsoft#4411 This change gives the azure plugin the ability to change the type of the credentials, but it will still have to override everything in ClientProvider to use the token credential. Maybe only a credential abstraction change could solve it, but it needs more discussions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4411
This change gives the azure plugin the ability to change the type of the credentials, but it will still have to override everything in ClientProvider to use the token credential.
Maybe only a credential abstraction change could solve it, but it needs more discussions.