Emitter framework handle circular references #2550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheeguerin
requested review from
bterlson,
daviwil,
markcowl and
allenjzhang
as code owners
timotheeguerin
changed the title
|
Changes in this PR will be published to the following url to try(check status of TypeSpec Pull Request Try It pipeline for publish status): Website: https://tspwebsitepr.z22.web.core.windows.net/prs/2550/ |
markcowl
approved these changes
Oct 13, 2023
bterlson
reviewed
Oct 20, 2023
bterlson
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emitter framework deals with circular reference for you and this works great if the circular flow involve declarations that can be referenced. But sometimes there is issues where we can't have a declaration and so a circular reference becomes impossible. Adding a new
circularReferencehook that gets called when we resolve a reference that is point back to itself in the resolution stack. By default it will throw resolve the declaration ref if the target is a declaration or throw an error.An emitter can decide to override this function to provide a different handling in either cases. A target language might not even support circular reference at all.