Stop publishing typespec-vscode/typespec-vs to npm & run build on Linux#11170
Draft
timotheeguerin wants to merge 1 commit into
Draft
Stop publishing typespec-vscode/typespec-vs to npm & run build on Linux#11170timotheeguerin wants to merge 1 commit into
timotheeguerin wants to merge 1 commit into
Conversation
Mark the typespec-vscode and typespec-vs packages as private so they are no longer published to npm (they are installed from their marketplaces). They stay in their chronus lockstep version policies so the extension versions keep advancing, matching the @typespec/standalone-cli pattern. Split the VS extension build (.NET/VS SDK, Windows) into a dedicated build-vs job so the main build-packages job runs on Linux, following the approach from #6907. Fixes part of #11168
microsoft-github-policy-service
Bot
added
ide
Contributor
|
No changes needing a change description found. |
|
You can try these changes here
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes part of #11168 (part 2). Re-implements the build optimization from the closed #6907.
Now that the VS Code and Visual Studio extensions are installed from their respective marketplaces (part 1, #11169), publishing
typespec-vscodeandtypespec-vsto npm is redundant. This PR stops publishing them and optimizes the build pipeline.Stop publishing to npm
typespec-vscodeandtypespec-vsas"private": true.chronus packiterates only non-private packages, so they drop out of thenpm-packages-*artifacts and are no longer pushed to npm.typespec-stable/typespec-preview), so the extension versions keep advancing for marketplace releases. This mirrors the existing@typespec/standalone-clipattern (private: true+ still in a lockstep policy).Optimize the build pipeline (re-implements #6907)
The
buildstage previously ran entirely on Windows solely to build the Visual Studio extension (.NET/VS SDK). This splits that out so the bulk of the build runs on Linux:build-for-publish.yml→build-packages.yml, moved it to a Linux pool, and setTYPESPEC_SKIP_VS_BUILD: true. It still builds/tests everything else and produces the npm packs, the VS Code.vsix, bundler packages, scenario manifest, and playground.build-vs.yml, a dedicated Windows job that builds only the VS extension (TYPESPEC_VS_CI_BUILD: true) and outputs thevs-extension-unsignedartifact (same name as before).publish.ymlto drop the stage-level Windows pool and reference both jobs.Artifact names (
npm-packages-stable,npm-packages-next,vscode-extension-unsigned,vs-extension-unsigned) and thebuildjob/pack step names are preserved, so the downstream sign/publish stages are unchanged.Validation
chronus verifypasses;pnpm install --frozen-lockfileis unaffected by theprivateflag.