Closed
[python] Fix Python preprocess handling for numeric YAML scalars#11143
Conversation
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix AttributeError in preprocess update_description
Fix Python preprocess handling for numeric YAML scalars
Jul 2, 2026
msyyc
reviewed
Jul 2, 2026
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
commit: |
Contributor
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
Contributor
|
move to #11162 |
msyyc
added a commit
to msyyc/typespec
that referenced
this pull request
Jul 3, 2026
The emitter force-quoting fix makes the non-string description/enum-name handling from microsoft#11143 unnecessary, so revert those pygen changes and their tests, leaving a focused emitter-only fix. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Python client preprocessor could crash when TypeSpec union enum values emitted numeric YAML scalars, e.g. date-like backtick labels. Numeric descriptions hit
rstrip, and numeric enum value names hit snake-case conversion.Preprocess normalization
Regression coverage
This now preprocesses without raising
AttributeErrororTypeErrorfrom Python string helpers.