OpenAPI3 - Fix CSV format representation (#2446)

Fixes #2234.
microsoft · Sep 20, 2023 · 8e3240a · 8e3240a
1 parent 4c1c6f3
commit 8e3240a
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 2 deletions.
diff --git a/common/changes/@typespec/openapi3/openapi3-FixCsvFormat_2023-09-19-21-04.json b/common/changes/@typespec/openapi3/openapi3-FixCsvFormat_2023-09-19-21-04.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@typespec/openapi3",
+      "comment": "Fix issue with CSV format representation.",
+      "type": "none"
+    }
+  ],
+  "packageName": "@typespec/openapi3"
+}
diff --git a/packages/openapi3/src/openapi.ts b/packages/openapi3/src/openapi.ts
@@ -1162,7 +1162,12 @@ function createOAPIEmitter(program: Program, options: ResolvedOpenAPI3EmitterOpt
     ph.in = parameter.type;
     if (parameter.type === "query" || parameter.type === "header") {
       if (parameter.format === "csv" || parameter.format === "simple") {
-        ph.style = "simple";
+        if (parameter.type === "query") {
+          ph.style = "form";
+          ph.explode = false;
+        } else {
+          ph.style = "simple";
+        }
       } else if (parameter.format === "multi" || parameter.format === "form") {
         if (parameter.type === "header") {
           reportDiagnostic(program, {

diff --git a/packages/openapi3/test/parameters.test.ts b/packages/openapi3/test/parameters.test.ts
@@ -54,7 +54,8 @@ describe("openapi3: parameters", () => {
     deepStrictEqual(params[1], {
       in: "query",
       name: "$csv",
-      style: "simple",
+      style: "form",
+      explode: false,
       schema: {
         type: "array",
         items: {