Eliminate ProgramOptions.ConfigFileName #976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the vestigial ProgramOptions.ConfigFileName and refactors configuration parsing by introducing tsoptions.GetParsedCommandLineOfConfigFile, shifting the responsibility for reading and parsing the config file outside of the Program creation.
- Removed old ConfigFileName handling from various packages.
- Updated all callers to use tsoptions.GetParsedCommandLineOfConfigFile and NewProgramFromParsedCommandLine.
- Cleaned up legacy code paths in program.go and associated tests.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/tsoptions/utilities.go | Added GetParsedCommandLineOfConfigFile to encapsulate config file reading and parsing |
| internal/execute/watcher.go | Updated call to use the new tsoptions.GetParsedCommandLineOfConfigFile function |
| internal/execute/tsc.go | Replaced legacy config file parsing call with the new function |
| internal/compiler/program_test.go | Updated tests to use the new config parsing API |
| internal/compiler/program.go | Removed ConfigFileName and legacy parsing logic; now directly uses RootFiles |
| internal/checker/checker_test.go | Updated tests to use NewProgramFromParsedCommandLine |
sheetalkamat
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is from back when the CLI was hacked-up. Now there's no reason to have it.