createProgram - #4914
Draft
Gabriela Araujo Britto (gabritto) wants to merge 10 commits into
Draft
Conversation
Copilot started reviewing on behalf of
Gabriela Araujo Britto (gabritto)
August 19, 2026 00:29
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Adds native createProgram support with isolated snapshots, incremental reuse, project references, diagnostics, and sync/async API exposure.
Changes:
- Adds server protocol and snapshot-backed program creation.
- Supports old-program reuse, file changes, references, and config diagnostics.
- Adds Go and TypeScript integration tests.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
internal/tsoptions/parsedcommandline.go |
Adds project references to parsed command lines. |
internal/tsoptions/commandlineparser.go |
Updates constructor usage. |
internal/project/snapshot.go |
Implements isolated program snapshots. |
internal/project/projectcollectionbuilder.go |
Updates synthetic inferred projects and reuse logic. |
internal/project/project.go |
Adds synthetic-project seeding and metadata propagation. |
internal/project/project_test.go |
Tests inferred-project option updates. |
internal/project/api.go |
Exposes program snapshot creation. |
internal/execute/tsc/emit_test.go |
Updates constructor usage. |
internal/compiler/projectreferenceparser.go |
Supports config-less reference roots. |
internal/compiler/projectreferencefilemapper.go |
Handles synthetic root config paths. |
internal/ast/diagnostic.go |
Adds text-based diagnostic construction. |
internal/api/session.go |
Handles createProgram requests. |
internal/api/session_createprogram_test.go |
Tests creation, reuse, references, and isolation. |
internal/api/proto.go |
Defines protocol types and diagnostic conversion. |
_packages/native-preview/test/sync/api.test.ts |
Adds synchronous API tests. |
_packages/native-preview/test/async/api.test.ts |
Adds asynchronous API tests. |
_packages/native-preview/src/api/sync/api.ts |
Exposes synchronous createProgram. |
_packages/native-preview/src/api/proto.ts |
Adds client protocol types. |
_packages/native-preview/src/api/async/api.ts |
Exposes asynchronous createProgram. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| func (d *DiagnosticResponse) ToDiagnostic() *ast.Diagnostic { | ||
| return ast.NewDiagnosticFromText( | ||
| nil, |
Member
Author
There was a problem hiding this comment.
I'll need something similar here to what we'll have to do to set up formatDiagnostics, i.e. retrieving a file from the file name associated to a JS-side diagnostic. I'll leave this like that until then.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…t/typescript-go into gabritto/create_program
| } | ||
|
|
||
| projectCollectionBuilder.DidChangeCustomConfigFileName(logger.Fork("DidChangeCustomConfigFileName")) | ||
| // compiler options changed, update inferred project and program |
Member
Author
There was a problem hiding this comment.
This is a drive-by fix, since I was already working on updateInferredProject.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
createProgramto the API.The API is similar to what we had in Strada, where we take root file names, compiler options, and optionally project references and config file parsing diagnostics, and return a program.
It also optionally takes an
oldProgramand file changes to apply to this old program to construct a new program.Because this API allows you to evolve a program over time by applying changes, its implementation is based on snapshots. So each program returned by this API has a corresponding snapshot to back it. But the process for creating such a snapshot is a little different from the usual: we want this snapshot to back only the one program we're creating. So there's a new
snapshot.cloneForProgramjust for that. The way it works is that we create a new synthetic inferred project during clone that will contain the root file names and compiler options that were provided viacreateProgram.The
oldProgramdoesn't necessarily have to be created bycreateProgrameither, but it does need to be backed by a server-side snapshot (this may need to change in the future: I'm not sure this would work for the programs created by the upcoming solution builder API).If an
oldProgramisn't provided, we rely on the updated server snapshot as a base for creating the program.