Warn on TSServer Plugin Contributions from other extensions by DanielRosenwasser · Pull Request #4063 · microsoft/typescript-go

Daniel Rosenwasser (DanielRosenwasser) · 2026-05-27T19:45:23Z

Fixes #3848

(Builds on #4052)

Fixes #3848.

No workspace, one extension

Workspace, 2 extensions

…js/ts over typescript.

…dence and resolution

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Copilot's findings

Files reviewed: 3/3 changed files
Comments generated: 5

+    const settingName = getWinningTsgoConfigKey()!;
+    assert(settingName !== undefined, "Expected some useTsgo configuration to be explicitly set.");
+
+    const target = getExplicitConfigTarget(vscode.workspace.getConfiguration(), settingName);


+    warnAboutTsServerPlugins(context, output);
+    context.subscriptions.push(vscode.extensions.onDidChange(() => {
+        warnAboutTsServerPlugins(context, output);


Daniel Rosenwasser (DanielRosenwasser) · 2026-05-27T21:55:41Z

+    const ok = "OK";
+    const disableInWorkspace = "Disable in Workspace";
+    const dontShowAgain = hasWorkspaceFolder ? "Don't Show Again in Workspace" : "Don't Show Again";
+
+    const options = [ok];
+    if (hasWorkspaceFolder) {
+        options.push(disableInWorkspace);
+    }
+    options.push(dontShowAgain);
+
+    const selected = await vscode.window.showWarningMessage(message, ...options);


Maybe we should just have some state so we don't show it more than once per session.

Andrew Branch (andrewbranch) · 2026-06-03T19:23:37Z

+
+        const message = uniqueExtensionNames.length === 1
+            // Pick the first extension & plugin, even though extensions can have multiple plugins
+            ? `The ${pluginExtensions[0].pluginName} plugin from the extension "${pluginExtensions[0].extensionId}" will not be applied because TypeScript Native Preview is enabled globally.`


The plugin name could use some quotes to lessen the "plugin plugin" effect

Suggested change

? `The ${pluginExtensions[0].pluginName} plugin from the extension "${pluginExtensions[0].extensionId}" will not be applied because TypeScript Native Preview is enabled globally.`

? `The "${pluginExtensions[0].pluginName}" plugin from the extension "${pluginExtensions[0].extensionId}" will not be applied because TypeScript Native Preview is enabled globally.`

Andrew Branch (andrewbranch) · 2026-06-03T19:25:15Z

+            : `${uniqueExtensionNames.length} extensions contribute TypeScript server plugins that will not be applied because TypeScript Native Preview is enabled globally: ${extensionNames}`;
+
+        const ok = "OK";
+        const disableInWorkspace = "Disable in Workspace";


I feel like it's a little confusing whether this is referring to disabling the third party plugin/extension or the TS Native Preview extension.

Andrew Branch (andrewbranch) · 2026-06-03T19:34:42Z

+
+        const ok = "OK";
+        const disableInWorkspace = "Disable in Workspace";
+        const dontShowAgain = hasWorkspaceFolder ? "Don't Show Again in Workspace" : "Don't Show Again";


I apparently installed the Svelte extension years ago when playing around with something, and it seems to activate on all JS/TS projects, regardless of whether they use Svelte. It's going to be frustrating for me to have to click "Don't Show Again in Workspace" for every workspace I open. I'll personally just end up uninstalling the Svelte extension, but I would be in a bit of a bind if I did occasionally work on a Svelte project and needed to keep the extension installed. Maybe this is Svelte's fault for activating over-liberally, but I'm afraid lots of users are going to be constantly nagged about extensions they don't rely on heavily and aren't relevant to most of their workspaces. I feel like the global "Don't Show Again" should always be available.

Copilot

Copilot's findings

Files reviewed: 3/3 changed files
Comments generated: 7

+export function defer(fn: () => void): Disposable {
+    return {
+        [Symbol.dispose]: fn,
+    };
+}


+    let pluginWarningShown = false;
+    const onDidChangeExtensions = vscode.extensions.onDidChange(() => {
+        warnAboutTsServerPlugins(context, output);
+    });
+    context.subscriptions.push(onDidChangeExtensions);
+    warnAboutTsServerPlugins(context, output);
+


+        // We only want to warn about plugins when Corsa is enabled in a user's the global configuration.
+        // Setting in the workspace is an indication that the user is aware of the potential issues.


+        if (context.globalState.get<true>(pluginWarningDismissedKey)) {
+            return;
+        }


…t#4063)

…t/typescript-go#4063)

Daniel Rosenwasser (DanielRosenwasser) added 6 commits May 26, 2026 10:28

Prefer js/ts settings when modifying useTsgo.

20410d0

Respect target specificity for configuration instead of just picking …

0922a48

…js/ts over typescript.

Fix bug where extension was always started even when useTsgo was false.

5eaedfd

fmt!

be39b3f

Clarify behavior of getUseTsgo function regarding configuration prece…

ee5fbdb

…dence and resolution

Warn when TSServer plugins are enabled.

734891d

Daniel Rosenwasser (DanielRosenwasser) changed the title ~~Warn on plugins~~ Warn on TSServer Plugin Contributios from other extensions May 27, 2026

Daniel Rosenwasser (DanielRosenwasser) marked this pull request as ready for review May 27, 2026 19:45

Copilot AI review requested due to automatic review settings May 27, 2026 19:45

Copilot AI reviewed May 27, 2026

Daniel Rosenwasser (DanielRosenwasser) requested a review from Copilot May 27, 2026 19:46

Copilot started reviewing on behalf of Daniel Rosenwasser (DanielRosenwasser) May 27, 2026 19:47 View session

Copilot AI reviewed May 27, 2026

View reviewed changes

Daniel Rosenwasser (DanielRosenwasser) added 2 commits May 27, 2026 12:55

Use the joined extension names.

5b67c41

-!

639b7b3

Daniel Rosenwasser (DanielRosenwasser) changed the title ~~Warn on TSServer Plugin Contributios from other extensions~~ Warn on TSServer Plugin Contributions from other extensions May 27, 2026

Daniel Rosenwasser (DanielRosenwasser) added 3 commits May 27, 2026 14:39

Move function into extension start to make closing over easier.

4fb5fa3

Disallow multiple warning dialogs at the same time.

3c33644

Merge remote-tracking branch 'origin/main' into warnOnPlugins

95e3c94

Ryan Cavanaugh (RyanCavanaugh) added this to the TypeScript 7.0 RC milestone May 28, 2026

Ryan Cavanaugh (RyanCavanaugh) requested a review from Andrew Branch (andrewbranch) June 3, 2026 17:46

Andrew Branch (andrewbranch) reviewed Jun 3, 2026

View reviewed changes

Daniel Rosenwasser (DanielRosenwasser) added 5 commits June 12, 2026 13:36

Merge remote-tracking branch 'origin/main' into warnOnPlugins

62d55ec

Merge remote-tracking branch 'origin/main' into warnOnPlugins

73a5493

Generate loc

0f4b395

Phrasing and broader "don't show again"

f41fe8c

Show at most once per activation.

87f87bb

Daniel Rosenwasser (DanielRosenwasser) requested review from Ryan Cavanaugh (RyanCavanaugh), Andrew Branch (andrewbranch) and Copilot June 12, 2026 23:08

Copilot started reviewing on behalf of Daniel Rosenwasser (DanielRosenwasser) June 12, 2026 23:09 View session

Copilot AI reviewed Jun 12, 2026

View reviewed changes

Daniel Rosenwasser (DanielRosenwasser) added 3 commits June 12, 2026 16:26

Format and remove unnecessary utilities.

e911274

Fix string.

b7014a4

Grammar

ef99936

Andrew Branch (andrewbranch) approved these changes Jun 15, 2026

View reviewed changes

Jake Bailey (jakebailey) modified the milestones: TypeScript 7.0 RC, TypeScript 7.0 Stable Jun 18, 2026

Daniel Rosenwasser (DanielRosenwasser) added this pull request to the merge queue Jun 22, 2026

Merged via the queue into main with commit 481a4aa Jun 22, 2026
21 checks passed

Daniel Rosenwasser (DanielRosenwasser) deleted the warnOnPlugins branch June 22, 2026 20:24

Ryan Hart (rhart92) pushed a commit to rhart92/typescript-go that referenced this pull request Aug 2, 2026

Warn on TSServer Plugin Contributions from other extensions (microsof…

7b5ced7

…t#4063)

Jake Bailey (jakebailey) pushed a commit to jakebailey/TypeScript that referenced this pull request Aug 13, 2026

Warn on TSServer Plugin Contributions from other extensions (microsof…

b709ea5

…t/typescript-go#4063)

Navigation Menu

Uh oh!

Warn on TSServer Plugin Contributions from other extensions - #4063

Warn on TSServer Plugin Contributions from other extensions#4063
Daniel Rosenwasser (DanielRosenwasser) merged 19 commits into
mainfrom
warnOnPlugins

Daniel Rosenwasser (DanielRosenwasser) commented May 27, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) May 27, 2026

Uh oh!

Uh oh!

Andrew Branch (andrewbranch) Jun 3, 2026

Uh oh!

Andrew Branch (andrewbranch) Jun 3, 2026

Uh oh!

Andrew Branch (andrewbranch) Jun 3, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	? `The ${pluginExtensions[0].pluginName} plugin from the extension "${pluginExtensions[0].extensionId}" will not be applied because TypeScript Native Preview is enabled globally.`
	? `The "${pluginExtensions[0].pluginName}" plugin from the extension "${pluginExtensions[0].extensionId}" will not be applied because TypeScript Native Preview is enabled globally.`

		// We only want to warn about plugins when Corsa is enabled in a user's the global configuration.
		// Setting in the workspace is an indication that the user is aware of the potential issues.

Uh oh!

Conversation

Daniel Rosenwasser (DanielRosenwasser) commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) May 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Andrew Branch (andrewbranch) Jun 3, 2026

Choose a reason for hiding this comment

Uh oh!

Andrew Branch (andrewbranch) Jun 3, 2026

Choose a reason for hiding this comment

Uh oh!

Andrew Branch (andrewbranch) Jun 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Daniel Rosenwasser (DanielRosenwasser) commented May 27, 2026 •

edited

Loading