fix: use utf8.DecodeLastRuneInString to correctly handle multi-byte runes in setLastNonTriviaPosition - #3712
Merged
Gabriela Araujo Britto (gabritto) merged 1 commit intoMay 5, 2026
Conversation
…unes in setLastNonTriviaPosition
Copilot started reviewing on behalf of
Oleksandr Tarasiuk (a-tarasyuk)
May 5, 2026 17:19
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes incorrect tracking of the last non-trivia text position when emitted text ends with a multi-byte whitespace rune (previously treated byte-by-byte), improving correctness of position assignment for printed nodes.
Changes:
- Update
setLastNonTriviaPositionto trim trailing whitespace usingutf8.DecodeLastRuneInStringinstead of indexing bytes. - Adjust position delta calculation to subtract the correct number of bytes removed.
Gabriela Araujo Britto (gabritto)
approved these changes
May 5, 2026
Jake Bailey (jakebailey)
pushed a commit
to jakebailey/TypeScript
that referenced
this pull request
Aug 13, 2026
…unes in setLastNonTriviaPosition (microsoft/typescript-go#3712)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3707 (comment)