Fix resolveJsonModule default for nodenext module#2657
Merged
jakebailey merged 3 commits intomainfrom Feb 3, 2026
Merged
Conversation
Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix
Fix resolveJsonModule default for nodenext module
Feb 3, 2026
resolveJsonModule for nodenext module
jakebailey
reviewed
Feb 3, 2026
Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where resolveJsonModule was not defaulting to true when the module compiler option is set to nodenext, causing errors when importing JSON files without explicitly setting the option.
Changes:
- Added
ModuleKindNodeNextto the switch case inGetResolveJsonModule()to ensure it defaults totruealongsideModuleKindNode20andModuleKindESNext
jakebailey
approved these changes
Feb 3, 2026
RyanCavanaugh
approved these changes
Feb 3, 2026
andrewbranch
approved these changes
Feb 3, 2026
Copilot AI
added a commit
that referenced
this pull request
Feb 25, 2026
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolveJsonModulewas not defaulting totruewhenmoduleisnodenext, causing errors when importing JSON files without explicitly setting the option.Changes
GetResolveJsonModule()to includeModuleKindNodeNextalongsideModuleKindNode20, and removedModuleKindESNextwhich shouldn't have been there per the TypeScript implementationOriginal prompt
resolveJsonModuleis not defaulted totruewhenmoduleisnodenext#2652✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.