Don’t use request context for sending responses #2568
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2499, we started checking for context cancelation during sending responses as a way to ensure we don’t get stuck trying to write a message to a client that has exited. If the context is canceled, we would bail out returning an error, but that error would eventually be ignored. Ignoring the error is a problem, but the big problem was that we were checking the request context during sending. If the request was canceled, we would try to send an error response saying the request was canceled, but we would fail to send it since the context was canceled. This left the client perpetually waiting for our response and never asking for new errors.
Fixes #2557