Skip to content

Fix hover on module.exports #2098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahejlsberg merged 7 commits into from
Nov 15, 2025
Merged

Fix hover on module.exports #2098

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4bbbff8
Hover on module in module.exports displays module name
ahejlsberg Nov 14, 2025
4f9f92d
Hover on exports in module.exports displays type or alias target
ahejlsberg Nov 14, 2025
8e2d4e9
Fix crash
ahejlsberg Nov 14, 2025
c24ece2
Accept new baselines
ahejlsberg Nov 14, 2025
990ccfa
Merge branch 'main' into hover-on-module-exports
ahejlsberg Nov 15, 2025
349e3a4
Update failingTests.txt
ahejlsberg Nov 15, 2025
e8fe1ee
Manually update tests
ahejlsberg Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions internal/checker/checker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30749,6 +30749,9 @@ func (c *Checker) getSymbolOfNameOrPropertyAccessExpression(name *ast.Node) *ast
}
meaning := core.IfElse(isJSDoc, ast.SymbolFlagsValue|ast.SymbolFlagsType|ast.SymbolFlagsNamespace, ast.SymbolFlagsValue)
result := c.resolveEntityName(name, meaning, true /*ignoreErrors*/, true /*dontResolveAlias*/, nil /*location*/)
if result != nil && result.Flags&ast.SymbolFlagsModuleExports != 0 {
result = result.ValueDeclaration.Symbol() // Symbol of the module source file
}
if result == nil && isJSDoc {
if container := ast.FindAncestor(name, ast.IsClassOrInterfaceLike); container != nil {
symbol := c.getSymbolOfDeclaration(container)
Expand Down
2 changes: 1 addition & 1 deletion internal/ls/findallreferences.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -753,7 +753,7 @@ func (l *LanguageService) getReferencedSymbolsForModuleIfDeclaredBySourceFile(ct
exportEquals := symbol.Exports[ast.InternalSymbolNameExportEquals]
// If exportEquals != nil, we're about to add references to `import("mod")` anyway, so don't double-count them.
moduleReferences := l.getReferencedSymbolsForModule(ctx, program, symbol, exportEquals != nil, sourceFiles, sourceFilesSet)
if exportEquals == nil || !sourceFilesSet.Has(moduleSourceFileName) {
if exportEquals == nil || exportEquals.Flags&ast.SymbolFlagsAlias == 0 || !sourceFilesSet.Has(moduleSourceFileName) {
return moduleReferences
}
symbol, _ = checker.ResolveAlias(exportEquals)
Expand Down
6 changes: 5 additions & 1 deletion internal/ls/hover.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,11 @@ func getQuickInfoAndDeclarationAtLocation(c *checker.Checker, symbol *ast.Symbol
}
}
}
b.WriteString(c.SymbolToStringEx(symbol, container, ast.SymbolFlagsNone, symbolFormatFlags))
if symbol.Name == ast.InternalSymbolNameExportEquals && symbol.Parent != nil && symbol.Parent.Flags&ast.SymbolFlagsModule != 0 {
b.WriteString("exports")
} else {
b.WriteString(c.SymbolToStringEx(symbol, container, ast.SymbolFlagsNone, symbolFormatFlags))
}
b.WriteString(": ")
if callNode := getCallOrNewExpression(node); callNode != nil {
b.WriteString(c.SignatureToStringEx(c.GetResolvedSignature(callNode), container, typeFormatFlags|checker.TypeFormatFlagsWriteCallStyleSignature|checker.TypeFormatFlagsWriteTypeArgumentsOfSignature|checker.TypeFormatFlagsWriteArrowStyleSignature))
Expand Down
4 changes: 2 additions & 2 deletions testdata/baselines/reference/compiler/erasableSyntaxOnlyJS.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import foo = require("./foo.js");
=== bar.cjs ===
module.exports = {
>module.exports : Symbol(export=, Decl(bar.cjs, 0, 0))
>module : Symbol(module.exports)
>module : Symbol("bar", Decl(bar.cjs, 0, 0))
>exports : Symbol(export=, Decl(bar.cjs, 0, 0))

a: 1,
Expand All @@ -21,7 +21,7 @@ module.exports = {
=== foo.js ===
module.exports = {
>module.exports : Symbol(export=, Decl(foo.js, 0, 0))
>module : Symbol(module.exports)
>module : Symbol("foo", Decl(foo.js, 0, 0))
>exports : Symbol(export=, Decl(foo.js, 0, 0))

b: 2,
Expand Down
2 changes: 1 addition & 1 deletion testdata/baselines/reference/compiler/panicSatisfiesOnExportEqualsDeclaration.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@
*/
module.exports = {};
>module.exports : Symbol(export=, Decl(panicSatisfiesOnExportEqualsDeclaration.js, 0, 0))
>module : Symbol(module.exports)
>module : Symbol("panicSatisfiesOnExportEqualsDeclaration", Decl(panicSatisfiesOnExportEqualsDeclaration.js, 0, 0))
>exports : Symbol(export=, Decl(panicSatisfiesOnExportEqualsDeclaration.js, 0, 0))

4 changes: 2 additions & 2 deletions ...baselines/reference/fourslash/documentHighlights/emptyExportFindReferences.baseline.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// === documentHighlights ===
// === /Foo.js ===
// /*HIGHLIGHTS*/module.exports = {
// /*HIGHLIGHTS*/[|module.exports = {
//
// }
// }|]
2 changes: 1 addition & 1 deletion testdata/baselines/reference/submodule/compiler/checkJsTypeDefNoUnusedLocalMarked.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,6 @@ export = Foo;

module.exports = /** @type {FooFun} */(void 0);
>module.exports : Symbol(export=, Decl(something.js, 0, 0))
>module : Symbol(module.exports)
>module : Symbol("something", Decl(something.js, 0, 0))
>exports : Symbol(export=, Decl(something.js, 0, 0))

2 changes: 1 addition & 1 deletion ...ata/baselines/reference/submodule/compiler/checkJsTypeDefNoUnusedLocalMarked.symbols.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@
->module.exports : Symbol(module.exports, Decl(something.js, 0, 0))
->module : Symbol(export=, Decl(something.js, 0, 0))
+>module.exports : Symbol(export=, Decl(something.js, 0, 0))
+>module : Symbol(module.exports)
+>module : Symbol("something", Decl(something.js, 0, 0))
Comment on lines 7 to +10
Copy link
Member

@jakebailey jakebailey Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of funky that before, module.exports was module.exports and module was export=, but now module.exports is export= and module is module name...

Copy link
Member Author

@ahejlsberg ahejlsberg Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the new behavior is defensible. The old one--not so much.

>exports : Symbol(export=, Decl(something.js, 0, 0))
2 changes: 1 addition & 1 deletion testdata/baselines/reference/submodule/compiler/commonJsExportTypeDeclarationError.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
=== test.js ===
module.exports = {
>module.exports : Symbol(export=, Decl(test.js, 0, 0))
>module : Symbol(module.exports)
>module : Symbol("test", Decl(test.js, 0, 0))
>exports : Symbol(export=, Decl(test.js, 0, 0))

message: ""
Expand Down
2 changes: 1 addition & 1 deletion ...ta/baselines/reference/submodule/compiler/commonJsExportTypeDeclarationError.symbols.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
->module.exports : Symbol(module.exports, Decl(test.js, 0, 0))
->module : Symbol(export=, Decl(test.js, 0, 0))
+>module.exports : Symbol(export=, Decl(test.js, 0, 0))
+>module : Symbol(module.exports)
+>module : Symbol("test", Decl(test.js, 0, 0))
>exports : Symbol(export=, Decl(test.js, 0, 0))

message: ""
Expand Down
2 changes: 1 addition & 1 deletion testdata/baselines/reference/submodule/compiler/commonJsIsolatedModules.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
=== index.js ===
module.exports = {}
>module.exports : Symbol(export=, Decl(index.js, 0, 0))
>module : Symbol(module.exports)
>module : Symbol("index", Decl(index.js, 0, 0))
>exports : Symbol(export=, Decl(index.js, 0, 0))

var x = 1
Expand Down
2 changes: 1 addition & 1 deletion testdata/baselines/reference/submodule/compiler/commonJsIsolatedModules.symbols.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
->module : Symbol(module, Decl(index.js, 0, 0))
->exports : Symbol(module.exports, Decl(index.js, 0, 0))
+>module.exports : Symbol(export=, Decl(index.js, 0, 0))
+>module : Symbol(module.exports)
+>module : Symbol("index", Decl(index.js, 0, 0))
+>exports : Symbol(export=, Decl(index.js, 0, 0))

var x = 1
Expand Down
6 changes: 3 additions & 3 deletions ...nce/submodule/compiler/ensureNoCrashExportAssignmentDefineProperrtyPotentialMerge.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const _item = require("./namespacer");

module.exports = 12;
>module.exports : Symbol(export=, Decl(index.js, 0, 38))
>module : Symbol(module.exports)
>module : Symbol("index", Decl(index.js, 0, 0))
>exports : Symbol(export=, Decl(index.js, 0, 38))

Object.defineProperty(module, "exports", { value: "oh no" });
Expand All @@ -29,7 +29,7 @@ A.bar = class Q {}

module.exports = A;
>module.exports : Symbol(A, Decl(namespacey.js, 0, 5))
>module : Symbol(module.exports)
>module : Symbol("namespacey", Decl(namespacey.js, 0, 0))
>exports : Symbol(A, Decl(namespacey.js, 0, 5))
>A : Symbol(A, Decl(namespacey.js, 0, 5))

Expand All @@ -53,7 +53,7 @@ Object.defineProperty(B, "NS", { value: "why though", writable: true });

module.exports = B;
>module.exports : Symbol(B, Decl(namespacer.js, 0, 5))
>module : Symbol(module.exports)
>module : Symbol("namespacer", Decl(namespacer.js, 0, 0))
>exports : Symbol(B, Decl(namespacer.js, 0, 5))
>B : Symbol(B, Decl(namespacer.js, 0, 5))

6 changes: 3 additions & 3 deletions ...ubmodule/compiler/ensureNoCrashExportAssignmentDefineProperrtyPotentialMerge.symbols.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
->module.exports : Symbol(module.exports, Decl(index.js, 0, 0))
->module : Symbol(export=, Decl(index.js, 0, 38))
+>module.exports : Symbol(export=, Decl(index.js, 0, 38))
+>module : Symbol(module.exports)
+>module : Symbol("index", Decl(index.js, 0, 0))
>exports : Symbol(export=, Decl(index.js, 0, 38))

Object.defineProperty(module, "exports", { value: "oh no" });
Expand Down Expand Up @@ -38,7 +38,7 @@
->exports : Symbol(export=, Decl(namespacey.js, 1, 18))
->A : Symbol(A, Decl(namespacey.js, 0, 5), Decl(namespacey.js, 0, 12))
+>module.exports : Symbol(A, Decl(namespacey.js, 0, 5))
+>module : Symbol(module.exports)
+>module : Symbol("namespacey", Decl(namespacey.js, 0, 0))
+>exports : Symbol(A, Decl(namespacey.js, 0, 5))
+>A : Symbol(A, Decl(namespacey.js, 0, 5))

Expand Down Expand Up @@ -73,6 +73,6 @@
->exports : Symbol(export=, Decl(namespacer.js, 2, 72))
->B : Symbol(B, Decl(namespacer.js, 0, 5), Decl(namespacer.js, 0, 12), Decl(namespacer.js, 2, 22))
+>module.exports : Symbol(B, Decl(namespacer.js, 0, 5))
+>module : Symbol(module.exports)
+>module : Symbol("namespacer", Decl(namespacer.js, 0, 0))
+>exports : Symbol(B, Decl(namespacer.js, 0, 5))
+>B : Symbol(B, Decl(namespacer.js, 0, 5))
4 changes: 2 additions & 2 deletions testdata/baselines/reference/submodule/compiler/expandoFunctionContextualTypesJs.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ function foo() {
*/
module.exports = {
>module.exports : Symbol(export=, Decl(input.js, 42, 1))
>module : Symbol(module.exports)
>module : Symbol("input", Decl(input.js, 0, 0))
>exports : Symbol(export=, Decl(input.js, 42, 1))

color: "red"
Expand All @@ -82,6 +82,6 @@ expectLiteral({ props: module.exports });
>expectLiteral : Symbol(expectLiteral, Decl(input.js, 27, 27))
>props : Symbol(props, Decl(input.js, 51, 15))
>module.exports : Symbol(export=, Decl(input.js, 42, 1))
>module : Symbol(module.exports)
>module : Symbol("input", Decl(input.js, 0, 0))
>exports : Symbol(export=, Decl(input.js, 42, 1))

4 changes: 2 additions & 2 deletions ...data/baselines/reference/submodule/compiler/expandoFunctionContextualTypesJs.symbols.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
->module.exports : Symbol(module.exports, Decl(input.js, 0, 0))
->module : Symbol(export=, Decl(input.js, 42, 1))
+>module.exports : Symbol(export=, Decl(input.js, 42, 1))
+>module : Symbol(module.exports)
+>module : Symbol("input", Decl(input.js, 0, 0))
>exports : Symbol(export=, Decl(input.js, 42, 1))

color: "red"
Expand All @@ -73,5 +73,5 @@
->module : Symbol(module, Decl(input.js, 42, 1), Decl(input.js, 51, 22))
->exports : Symbol(module.exports, Decl(input.js, 0, 0))
+>module.exports : Symbol(export=, Decl(input.js, 42, 1))
+>module : Symbol(module.exports)
+>module : Symbol("input", Decl(input.js, 0, 0))
+>exports : Symbol(export=, Decl(input.js, 42, 1))
2 changes: 1 addition & 1 deletion ...ce/submodule/compiler/importHelpersCommonJSJavaScript(verbatimmodulesyntax=false).symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class Bar extends Foo {}

module.exports = Bar;
>module.exports : Symbol(Bar, Decl(index.js, 0, 12))
>module : Symbol(module.exports)
>module : Symbol("/index", Decl(index.js, 0, 0))
>exports : Symbol(Bar, Decl(index.js, 0, 12))
>Bar : Symbol(Bar, Decl(index.js, 0, 12))

2 changes: 1 addition & 1 deletion ...bmodule/compiler/importHelpersCommonJSJavaScript(verbatimmodulesyntax=false).symbols.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@
->module : Symbol(export=, Decl(index.js, 2, 24))
->exports : Symbol(export=, Decl(index.js, 2, 24))
+>module.exports : Symbol(Bar, Decl(index.js, 0, 12))
+>module : Symbol(module.exports)
+>module : Symbol("/index", Decl(index.js, 0, 0))
+>exports : Symbol(Bar, Decl(index.js, 0, 12))
>Bar : Symbol(Bar, Decl(index.js, 0, 12))
2 changes: 1 addition & 1 deletion ...nce/submodule/compiler/importHelpersCommonJSJavaScript(verbatimmodulesyntax=true).symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class Bar extends Foo {}

module.exports = Bar;
>module.exports : Symbol(Bar, Decl(index.js, 0, 12))
>module : Symbol(module.exports)
>module : Symbol("/index", Decl(index.js, 0, 0))
>exports : Symbol(Bar, Decl(index.js, 0, 12))
>Bar : Symbol(Bar, Decl(index.js, 0, 12))

2 changes: 1 addition & 1 deletion ...ubmodule/compiler/importHelpersCommonJSJavaScript(verbatimmodulesyntax=true).symbols.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@
->module : Symbol(export=, Decl(index.js, 2, 24))
->exports : Symbol(export=, Decl(index.js, 2, 24))
+>module.exports : Symbol(Bar, Decl(index.js, 0, 12))
+>module : Symbol(module.exports)
+>module : Symbol("/index", Decl(index.js, 0, 0))
+>exports : Symbol(Bar, Decl(index.js, 0, 12))
>Bar : Symbol(Bar, Decl(index.js, 0, 12))
2 changes: 1 addition & 1 deletion testdata/baselines/reference/submodule/compiler/importNonExportedMember12.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
=== /node_modules/foo/src/index.js ===
module.exports = 1;
>module.exports : Symbol(export=, Decl(index.js, 0, 0))
>module : Symbol(module.exports)
>module : Symbol("/node_modules/foo/src/index", Decl(index.js, 0, 0))
>exports : Symbol(export=, Decl(index.js, 0, 0))

=== /a.js ===
Expand Down
2 changes: 1 addition & 1 deletion testdata/baselines/reference/submodule/compiler/importNonExportedMember12.symbols.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
->module.exports : Symbol(module.exports, Decl(index.js, 0, 0))
->module : Symbol(export=, Decl(index.js, 0, 0))
+>module.exports : Symbol(export=, Decl(index.js, 0, 0))
+>module : Symbol(module.exports)
+>module : Symbol("/node_modules/foo/src/index", Decl(index.js, 0, 0))
>exports : Symbol(export=, Decl(index.js, 0, 0))

=== /a.js ===
Expand Down
2 changes: 1 addition & 1 deletion testdata/baselines/reference/submodule/compiler/javascriptCommonjsModule.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class Bar extends Foo {}

module.exports = Bar;
>module.exports : Symbol(Bar, Decl(index.js, 0, 12))
>module : Symbol(module.exports)
>module : Symbol("index", Decl(index.js, 0, 0))
>exports : Symbol(Bar, Decl(index.js, 0, 12))
>Bar : Symbol(Bar, Decl(index.js, 0, 12))

2 changes: 1 addition & 1 deletion testdata/baselines/reference/submodule/compiler/javascriptCommonjsModule.symbols.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@
->module : Symbol(export=, Decl(index.js, 2, 24))
->exports : Symbol(export=, Decl(index.js, 2, 24))
+>module.exports : Symbol(Bar, Decl(index.js, 0, 12))
+>module : Symbol(module.exports)
+>module : Symbol("index", Decl(index.js, 0, 0))
+>exports : Symbol(Bar, Decl(index.js, 0, 12))
>Bar : Symbol(Bar, Decl(index.js, 0, 12))
2 changes: 1 addition & 1 deletion testdata/baselines/reference/submodule/compiler/javascriptImportDefaultBadExport.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const alias = {};

module.exports = alias;
>module.exports : Symbol(alias, Decl(a.js, 0, 5))
>module : Symbol(module.exports)
>module : Symbol("/a", Decl(a.js, 0, 0))
>exports : Symbol(alias, Decl(a.js, 0, 5))
>alias : Symbol(alias, Decl(a.js, 0, 5))

Expand Down
2 changes: 1 addition & 1 deletion ...data/baselines/reference/submodule/compiler/javascriptImportDefaultBadExport.symbols.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
->module : Symbol(export=, Decl(a.js, 0, 17))
->exports : Symbol(export=, Decl(a.js, 0, 17))
+>module.exports : Symbol(alias, Decl(a.js, 0, 5))
+>module : Symbol(module.exports)
+>module : Symbol("/a", Decl(a.js, 0, 0))
+>exports : Symbol(alias, Decl(a.js, 0, 5))
>alias : Symbol(alias, Decl(a.js, 0, 5))

Expand Down
2 changes: 1 addition & 1 deletion testdata/baselines/reference/submodule/compiler/jsDeclarationEmitExportAssignedArray.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
=== file.js ===
module.exports = [{ name: 'other', displayName: 'Other', defaultEnabled: true }];
>module.exports : Symbol(export=, Decl(file.js, 0, 0))
>module : Symbol(module.exports)
>module : Symbol("file", Decl(file.js, 0, 0))
>exports : Symbol(export=, Decl(file.js, 0, 0))
>name : Symbol(name, Decl(file.js, 0, 19))
>displayName : Symbol(displayName, Decl(file.js, 0, 34))
Expand Down
2 changes: 1 addition & 1 deletion .../baselines/reference/submodule/compiler/jsDeclarationEmitExportAssignedArray.symbols.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
->module.exports : Symbol(module.exports, Decl(file.js, 0, 0))
->module : Symbol(export=, Decl(file.js, 0, 0))
+>module.exports : Symbol(export=, Decl(file.js, 0, 0))
+>module : Symbol(module.exports)
+>module : Symbol("file", Decl(file.js, 0, 0))
>exports : Symbol(export=, Decl(file.js, 0, 0))
>name : Symbol(name, Decl(file.js, 0, 19))
>displayName : Symbol(displayName, Decl(file.js, 0, 34))
2 changes: 1 addition & 1 deletion ...ubmodule/compiler/jsDeclarationEmitExportAssignedFunctionWithExtraTypedefsMembers.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
*/
module.exports = function loader(options) {}
>module.exports : Symbol(export=, Decl(index.js, 0, 0))
>module : Symbol(module.exports)
>module : Symbol("index", Decl(index.js, 0, 0))
>exports : Symbol(export=, Decl(index.js, 0, 0))
>loader : Symbol(loader, Decl(index.js, 8, 16))
>options : Symbol(options, Decl(index.js, 8, 33))
Expand Down
2 changes: 1 addition & 1 deletion ...ule/compiler/jsDeclarationEmitExportAssignedFunctionWithExtraTypedefsMembers.symbols.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
->module.exports : Symbol(module.exports, Decl(index.js, 0, 0))
->module : Symbol(export=, Decl(index.js, 0, 0))
+>module.exports : Symbol(export=, Decl(index.js, 0, 0))
+>module : Symbol(module.exports)
+>module : Symbol("index", Decl(index.js, 0, 0))
>exports : Symbol(export=, Decl(index.js, 0, 0))
>loader : Symbol(loader, Decl(index.js, 8, 16))
>options : Symbol(options, Decl(index.js, 8, 33))
2 changes: 1 addition & 1 deletion testdata/baselines/reference/submodule/compiler/jsExportAssignmentNonMutableLocation.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const customSymbol = Symbol("custom");
// This is a common pattern in Node’s built-in modules:
module.exports = {
>module.exports : Symbol(export=, Decl(file.js, 0, 38))
>module : Symbol(module.exports)
>module : Symbol("file", Decl(file.js, 0, 0))
>exports : Symbol(export=, Decl(file.js, 0, 38))

customSymbol,
Expand Down
2 changes: 1 addition & 1 deletion .../baselines/reference/submodule/compiler/jsExportAssignmentNonMutableLocation.symbols.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
->module : Symbol(module, Decl(file.js, 0, 38))
->exports : Symbol(module.exports, Decl(file.js, 0, 0))
+>module.exports : Symbol(export=, Decl(file.js, 0, 38))
+>module : Symbol(module.exports)
+>module : Symbol("file", Decl(file.js, 0, 0))
+>exports : Symbol(export=, Decl(file.js, 0, 38))

customSymbol,
Expand Down
2 changes: 1 addition & 1 deletion ...baselines/reference/submodule/compiler/jsExportMemberMergedWithModuleAugmentation.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class Abcde {

module.exports = {
>module.exports : Symbol(export=, Decl(test.js, 3, 1))
>module : Symbol(module.exports)
>module : Symbol("/test", Decl(test.js, 0, 0))
>exports : Symbol(export=, Decl(test.js, 3, 1))

Abcde
Expand Down
2 changes: 1 addition & 1 deletion ...ines/reference/submodule/compiler/jsExportMemberMergedWithModuleAugmentation.symbols.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
->module : Symbol(module, Decl(test.js, 3, 1))
->exports : Symbol("/test.js", Decl(test.js, 0, 0), Decl(index.ts, 0, 31))
+>module.exports : Symbol(export=, Decl(test.js, 3, 1))
+>module : Symbol(module.exports)
+>module : Symbol("/test", Decl(test.js, 0, 0))
+>exports : Symbol(export=, Decl(test.js, 3, 1))

Abcde
Expand Down
2 changes: 1 addition & 1 deletion ...aselines/reference/submodule/compiler/jsExportMemberMergedWithModuleAugmentation2.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
=== /test.js ===
module.exports = {
>module.exports : Symbol(export=, Decl(test.js, 0, 0))
>module : Symbol(module.exports)
>module : Symbol("/test", Decl(test.js, 0, 0))
>exports : Symbol(export=, Decl(test.js, 0, 0))

a: "ok"
Expand Down
2 changes: 1 addition & 1 deletion ...nes/reference/submodule/compiler/jsExportMemberMergedWithModuleAugmentation2.symbols.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
->module : Symbol("/test.js", Decl(test.js, 0, 0), Decl(index.ts, 0, 27))
->exports : Symbol("/test.js", Decl(test.js, 0, 0), Decl(index.ts, 0, 27))
+>module.exports : Symbol(export=, Decl(test.js, 0, 0))
+>module : Symbol(module.exports)
+>module : Symbol("/test", Decl(test.js, 0, 0))
+>exports : Symbol(export=, Decl(test.js, 0, 0))

a: "ok"
Expand Down
4 changes: 2 additions & 2 deletions ...aselines/reference/submodule/compiler/jsExportMemberMergedWithModuleAugmentation3.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@
=== /x.js ===
module.exports.x = 1;
>module.exports : Symbol(export=, Decl(x.js, 0, 21))
>module : Symbol(module.exports)
>module : Symbol("/x", Decl(x.js, 0, 0))
>exports : Symbol(export=, Decl(x.js, 0, 21))

module.exports = require("./y.js");
>module.exports : Symbol(export=, Decl(x.js, 0, 21))
>module : Symbol(module.exports)
>module : Symbol("/x", Decl(x.js, 0, 0))
>exports : Symbol(export=, Decl(x.js, 0, 21))
>require : Symbol(require)

Expand Down
Loading
Loading