lsp: Check diagnostic refresh capabilities against nil values & support more clients #1398
+10
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this patching required? You said in the issue that the protocol was fine, so I was expecting a change that just did a nil check. |
|
No, it's not. I opened this PR before I wrote the comment in question. I'll fix up this PR in a bit. |
osiewicz
force-pushed
the
1396-check-diagnostic-support-in-caps-against-nil
branch
from
9327e71 to
e5e1a27
Compare
jakebailey
reviewed
Jul 12, 2025
jakebailey
approved these changes
Jul 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1396