Port es2021 transform #1372
Merged
Port es2021 transform #1372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR ports the ES2021 logical assignment operators (&&=, ||=, ??=) into the compiler’s transform pipeline, refactors shared utilities for expression handling, and updates the emitted JavaScript baselines across multiple compilation targets.
- Introduces a new
IsSimpleCopiableExpressionhelper to decide when to inline expressions without temp variables. - Refactors the module transformer to use the shared “simple copiable” utility and removes duplication.
- Implements a
logicalAssignmentTransformerthat rewritesx &&= y(and friends) intox && (x = y)when downleveling. - Updates dozens of test baseline files to reflect the new transform output.
Reviewed Changes
Copilot reviewed 49 out of 49 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/transformers/utilities.go | Adds IsSimpleCopiableExpression helper for reuse in transforms |
| internal/transformers/moduletransforms/utilities.go | Removes local copy of copiable check; calls the shared helper |
| internal/transformers/estransforms/logicalassignment.go | Implements the logical assignment downlevel transform |
| testdata/baselines/reference/submodule/conformance/logicalAssignment*.js* | Updates emitted-downlevel patterns for &&=, ` |
jakebailey
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which is just the logical assignment operators -
&&=,||=, and??=.