Port TypeScript PR #60262: Include non-enumerable keys in __importStar helper #1124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports the changes from microsoft/TypeScript#60262 to include non-enumerable properties when importing modules with
import * as
syntax.Problem
The previous
__importStar
helper only included enumerable properties when performing star imports, which could miss important non-enumerable properties that should be part of the imported namespace.Solution
Updated the
__importStar
helper to useObject.getOwnPropertyNames()
(with fallback) instead of a simplefor...in
loop. This ensures both enumerable and non-enumerable properties are included.Before:
After:
Changes Made
importStarHelper.Text
ininternal/printer/helpers.go
internal/transformers/commonjsmodule_test.go
Test Results
This change ensures the Go port maintains compatibility with the latest TypeScript behavior for star imports.
Fixes #1119.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.