-
Notifications
You must be signed in to change notification settings - Fork 655
Issue implicit any in JS files on widened inferred types from initializers in binding patterns #1064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Andarist
wants to merge
2
commits into
microsoft:main
Choose a base branch
from
Andarist:fix/issue-implicit-any-widening-binding-patterns
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Issue implicit any in JS files on widened inferred types from initializers in binding patterns #1064
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58 changes: 58 additions & 0 deletions
58
...eference/submodule/conformance/destructuringParameterDeclaration9(strict=true).errors.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| index.js(7,9): error TS7031: Binding element 'json' implicitly has an 'any[]' type. | ||
| index.js(15,9): error TS7031: Binding element 'json' implicitly has an 'any[]' type. | ||
| index.js(37,20): error TS7031: Binding element 'json' implicitly has an 'any[]' type. | ||
| index.js(42,15): error TS7031: Binding element 'json' implicitly has an 'any[]' type. | ||
|
|
||
|
|
||
| ==== index.js (4 errors) ==== | ||
| /** | ||
| * @param {Object} [config] | ||
| * @param {Partial<Record<'json' | 'jsonc' | 'json5', string[]>>} [config.additionalFiles] | ||
| */ | ||
| export function prepareConfig({ | ||
| additionalFiles: { | ||
| json = [] | ||
| ~~~~ | ||
| !!! error TS7031: Binding element 'json' implicitly has an 'any[]' type. | ||
| } = {} | ||
| } = {}) { | ||
| json // string[] | ||
| } | ||
|
|
||
| export function prepareConfigWithoutAnnotation({ | ||
| additionalFiles: { | ||
| json = [] | ||
| ~~~~ | ||
| !!! error TS7031: Binding element 'json' implicitly has an 'any[]' type. | ||
| } = {} | ||
| } = {}) { | ||
| json | ||
| } | ||
|
|
||
| /** @type {(param: { | ||
| additionalFiles?: Partial<Record<"json" | "jsonc" | "json5", string[]>>; | ||
| }) => void} */ | ||
| export const prepareConfigWithContextualSignature = ({ | ||
| additionalFiles: { | ||
| json = [] | ||
| } = {} | ||
| } = {})=> { | ||
| json // string[] | ||
| } | ||
|
|
||
| // Additional repros from https://github.com/microsoft/TypeScript/issues/59936 | ||
|
|
||
| /** | ||
| * @param {{ a?: { json?: string[] }}} [config] | ||
| */ | ||
| function f1({ a: { json = [] } = {} } = {}) { return json } | ||
| ~~~~ | ||
| !!! error TS7031: Binding element 'json' implicitly has an 'any[]' type. | ||
|
|
||
| /** | ||
| * @param {[[string[]?]?]} [x] | ||
| */ | ||
| function f2([[json = []] = []] = []) { return json } | ||
| ~~~~ | ||
| !!! error TS7031: Binding element 'json' implicitly has an 'any[]' type. | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
80 changes: 33 additions & 47 deletions
80
...oduleAccepted/conformance/destructuringParameterDeclaration9(strict=true).errors.txt.diff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,53 +1,39 @@ | ||
| --- old.destructuringParameterDeclaration9(strict=true).errors.txt | ||
| +++ new.destructuringParameterDeclaration9(strict=true).errors.txt | ||
| @@= skipped -0, +0 lines =@@ | ||
| -index.js(15,9): error TS7031: Binding element 'json' implicitly has an 'any[]' type. | ||
| +index.js(7,9): error TS7031: Binding element 'json' implicitly has an 'any[]' type. | ||
| index.js(15,9): error TS7031: Binding element 'json' implicitly has an 'any[]' type. | ||
| - | ||
| - | ||
| -==== index.js (1 errors) ==== | ||
| - /** | ||
| - * @param {Object} [config] | ||
| - * @param {Partial<Record<'json' | 'jsonc' | 'json5', string[]>>} [config.additionalFiles] | ||
| - */ | ||
| - export function prepareConfig({ | ||
| - additionalFiles: { | ||
| - json = [] | ||
| - } = {} | ||
| - } = {}) { | ||
| - json // string[] | ||
| - } | ||
| - | ||
| - export function prepareConfigWithoutAnnotation({ | ||
| - additionalFiles: { | ||
| - json = [] | ||
| - ~~~~ | ||
| -!!! error TS7031: Binding element 'json' implicitly has an 'any[]' type. | ||
| - } = {} | ||
| - } = {}) { | ||
| - json | ||
| - } | ||
| - | ||
| - /** @type {(param: { | ||
| - additionalFiles?: Partial<Record<"json" | "jsonc" | "json5", string[]>>; | ||
| - }) => void} */ | ||
| - export const prepareConfigWithContextualSignature = ({ | ||
| - additionalFiles: { | ||
| - json = [] | ||
| - } = {} | ||
| - } = {})=> { | ||
| - json // string[] | ||
| - } | ||
| - | ||
| - // Additional repros from https://github.com/microsoft/TypeScript/issues/59936 | ||
| - | ||
| - /** | ||
| - * @param {{ a?: { json?: string[] }}} [config] | ||
| - */ | ||
| - function f1({ a: { json = [] } = {} } = {}) { return json } | ||
| - | ||
| - /** | ||
| - * @param {[[string[]?]?]} [x] | ||
| - */ | ||
| - function f2([[json = []] = []] = []) { return json } | ||
| - | ||
| +<no content> | ||
| +index.js(37,20): error TS7031: Binding element 'json' implicitly has an 'any[]' type. | ||
| +index.js(42,15): error TS7031: Binding element 'json' implicitly has an 'any[]' type. | ||
| + | ||
| + | ||
| +==== index.js (4 errors) ==== | ||
| /** | ||
| * @param {Object} [config] | ||
| * @param {Partial<Record<'json' | 'jsonc' | 'json5', string[]>>} [config.additionalFiles] | ||
| @@= skipped -8, +11 lines =@@ | ||
| export function prepareConfig({ | ||
| additionalFiles: { | ||
| json = [] | ||
| + ~~~~ | ||
| +!!! error TS7031: Binding element 'json' implicitly has an 'any[]' type. | ||
| } = {} | ||
| } = {}) { | ||
| json // string[] | ||
| @@= skipped -32, +34 lines =@@ | ||
| * @param {{ a?: { json?: string[] }}} [config] | ||
| */ | ||
| function f1({ a: { json = [] } = {} } = {}) { return json } | ||
| + ~~~~ | ||
| +!!! error TS7031: Binding element 'json' implicitly has an 'any[]' type. | ||
|
|
||
| /** | ||
| * @param {[[string[]?]?]} [x] | ||
| */ | ||
| function f2([[json = []] = []] = []) { return json } | ||
| + ~~~~ | ||
| +!!! error TS7031: Binding element 'json' implicitly has an 'any[]' type. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also tried porting this and hit these same issues. I'm pretty sure these are exactly the things that we are aiming to prevent, but now I think the fix doesn't quite work anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll take a look at this tomorrow~ then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR aims to issue implicit any error - and it does that... to some extent 😉 It is overly eager though. From what I can see, this one is still not handled by the reparser - and that's why we are seeing errors here. The compiler thinks it doesn't have a type annotation