Return group errors #110
Merged
Return group errors #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 12, 2023 21:21
This reverts commit dd74c5f.
jakebailey
reviewed
Apr 13, 2023
src/main.ts
Outdated
Comment on lines
463
to
464
| console.log("Extracting commit SHA for repro steps"); | ||
| const commit = (await execAsync(summary.repoDir, `git rev-parse @`)).trim(); | ||
| text += `<li>In dir <code>${summary.repo.name}</code>, run <code>git reset --hard ${commit}</code></li>\n`; | ||
| text += `<li>In dir <code>${summary.repo.name}</code>, run <code>git reset --hard ${summary.commit}</code></li>\n`; |
There was a problem hiding this comment.
This will end up being a behavior change; this try/catch was for the exec but now it doesn't do anything here, but can do something in the place it was moved to. I would try catch over in the new place to preserve this behavior.
There was a problem hiding this comment.
You're correct. Fixed. Instead, I now have the try-catch where the commit is extracted and also assigned a nullable value in case we don't get it.
jakebailey
approved these changes
Apr 17, 2023
|
We can only test it if it's on a branch on the repo itself. |
Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returns #105
Fixes the issue caused by this same PR as well. The bug was caused by
tmpfsbeing unmounted before using the files for reporting. Now, we read all of the necessary files before unmounting.I appreciate if I can get a review on the latest commit on this PR. (The one that introduces the fix).