Refactor build queueing, add new perf pipeline under new name #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
PR is not quite right; the old perf builds should be running in a specific pool so I have to figure out if the new API supports that. Maybe it doesn't matter and I can just stick my new perf change into this PR. |
Member
Author
|
Yeah, seems like you can't set the build queue in this new API. I guess I'll either have to revert this and make it able to use both APIs, or just bite the bullet and put my new change in here with the assumption that we'll never need to specify a queue again. |
jakebailey
changed the title
Member
|
Is this ready to review now? |
Member
Author
|
Yes, after one change I just pushed. |
Member
Author
|
I'd recommend reading the diff without whitespace: https://github.com/microsoft/typescript-bot-test-triggerer/pull/29/files?w=1 |
andrewbranch
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the code to use the new pipelines run API rather than the old build queueing API. The new API gets rid of the wart that required parameters be stored as strings (my favorite comment, "This API is real bad") in favor of an object. The downside is that they haven't exposed this API directly in the Node client yet (microsoft/azure-devops-node-api#519), but it wasn't hard to figure out via watching the UI requests and reading the Go API client which does support this API.This allows allow me to change the perf run tasks to specify the new pipeline and use new repo resources (which I've chosen over what typescript-error-deltas does via a param as it works better in the UI; we could change the error deltas pipelines at some point too).From what I can tell, the new API should still work on the old builds; I tested a few by hand and they worked, but it's a little hard to tell for the old-style UI pipelines which don't exactly have a "real" parameters set. I'm going to try and double check for each of these, though.This PR has changed since I sent it, but it effectively abstracts away the pipeline/build triggering sep a bit, leaving the original ones unchanged, and adds a new pipeline trigger for the new perf stuff, which will eventually just replace the old one.