This repository was archived by the owner on Jun 11, 2020. It is now read-only.
Reduce size of types-registry #429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
mhegazy
reviewed
Jan 24, 2018
src/publish-registry.ts
Outdated
| // Don't include not-needed packages in the registry. | ||
| const typings = await AllPackages.readTypings(); | ||
| const registry = JSON.stringify(await generateRegistry(typings), undefined, 4); | ||
| const registry = JSON.stringify(await generateRegistry(typings), undefined); |
Contributor
There was a problem hiding this comment.
you do not need the second undefined parameter either.
mhegazy
approved these changes
Jan 24, 2018
ghost
approved these changes
Jan 25, 2018
|
Could we just leave it as |
ghost
merged commit
ghost
reviewed
Jan 25, 2018
| const info = await fetchNpmInfo(typing.fullEscapedNpmName); | ||
| entries[typing.name] = info["dist-tags"]; | ||
| const tags = info["dist-tags"]; | ||
| if (tags) { |
Contributor
Author
There was a problem hiding this comment.
It wasn't when I was testing it. not sure why.
Contributor
Author
|
I use the version in the registry to decide in the installer whether or not I need to update the installed copy. So I don't think keeping the |
Merged
uniqueiniquity
added a commit
that referenced
this pull request
Jan 30, 2018
Port #429 to production
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#425 increased the number of lines in types-registry by a factor of 10 since a version was listed for every version of typescript (plus latest) for every package.
This change removes all whitespace from the registry and only lists tags that differ from the latest version.