Consider Certs In NODE_EXTRA_CA_CERTS

[Jacksondr5]

Feature Request

Consider certificates referenced by NODE_EXTRA_CA_CERTS

Impacted Code

typed-rest-client/lib/HttpClient.ts

Lines 124 to 142 in c99dbbe

	this._certConfig = requestOptions.cert;
	if (this._certConfig) {
	// If using cert, need fs
	fs = require('fs');
	// cache the cert content into memory, so we don't have to read it from disk every time
	if (this._certConfig.caFile && fs.existsSync(this._certConfig.caFile)) {
	this._ca = fs.readFileSync(this._certConfig.caFile, 'utf8');
	}
	if (this._certConfig.certFile && fs.existsSync(this._certConfig.certFile)) {
	this._cert = fs.readFileSync(this._certConfig.certFile, 'utf8');
	}
	if (this._certConfig.keyFile && fs.existsSync(this._certConfig.keyFile)) {
	this._key = fs.readFileSync(this._certConfig.keyFile, 'utf8');
	}
	}

A check for the env variable should probably happen around here. I'm not sure if it would be better to have the ICertConfiguration options merge with anything found in the environment variable or just overwrite the environment variable in favor of the supplied certs.

Use Case

As the node PR explains, self-signed certs are commonly used in closed environments.

My organization has recently encountered this problem with several TFS extensions. Using the environment variable solved the problem when extensions were using node HTTP clients, but there are a few extensions that use this library and do not surface a way for us to provide certs example from NuGetToolGetter

I'm happy to take a stab at it if desired.

[jtpetty]

@Jacksondr5 - I think the issue is that by default, the agent uses Node 6 and NODE_EXTRA_CA_CERTS was added in Node 7.3.

Can you try setting the environment variable AGENT_USE_NODE10=true for your job and then try using the NODE_EXTRA_CA_CERTS variable?

[Jacksondr5]

@jtpetty Thanks for the reply. We'll try that environment variable out and let you know how it works

[Jacksondr5]

@jtpetty Unfortunately, that didn't seem to have any effect. We're still seeing certificate errors.

[jtpetty]

@mjroghelia - Can you take a look at this one?

[github-actions]

This issue has had no activity in 90 days. Please comment if it is not actually stale