feat: Add class private field helper methods #79
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
@ExE-Boss thanks for looking into this. @Neuroboy23 opened #77 earlier to use the same helpers as in microsoft/TypeScript#30829 I see that the helpers in this PR (#79) are different from the ones in microsoft/TypeScript#30829. My understanding is that ideally the helpers would match, so TS users don't get different behavior dependong on whether or not they are using tslib. Am I understanding correctly? I haven't contributed to tslib before, so don't know what's normal. |
|
I created this with the expectation that microsoft/TypeScript#30829 would be changed to use property descriptors like what Babel does. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR to TypeScript#30829.