Skip to content

maybe setters needed? #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

dim0nickb
Copy link

hello. this new npm package version 1.12... is used by typeorm
and we have issue because our app broke with runtime error "TypeError: Cannot set property of # which has only a getter"
maybe this fix be helpful

@msftclas
Copy link

msftclas commented May 13, 2020

CLA assistant check
All CLA requirements met.

Copy link

@AndreasWintherMoen AndreasWintherMoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the TypeORM issue.

@wachunga
Copy link

Ran into this issue today as well with tslib 2.0.2. Downgrading to an earlier version avoids the issue.

@rbuckton
Copy link
Contributor

rbuckton commented Jan 5, 2021

Imported bindings are immutable per the ES2015 spec. What version TypeORM are you using and do you have a stack trace for the error?

@dim0nickb
Copy link
Author

Imported bindings are immutable per the ES2015 spec. What version TypeORM are you using and do you have a stack trace for the error?

Hello. Sorry, but i don't have stacktrace now. On 13 May 2020 we used "typeorm": "0.2.24". After update on tslib 1.12 we found an issue and revert tslib to 1.11.1 and it work fine till now.

@rbuckton
Copy link
Contributor

rbuckton commented Jan 7, 2021

Its possible this could be related to an issue with default exports that was fixed in microsoft/TypeScript#38808 and #116. I'd recommend you test with the latest version of tslib and, if there is still an issue, please report back with a stacktrace so that we might investigate further.

Since mutable import bindings do not match the ECMAScript spec, I don't believe this PR can move forward.

@rbuckton rbuckton closed this Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants