__values causes an infinite loop on Sets when Symbol.iterator isn't defined

[nevir]

Environment: https://github.com/convoyinc/apollo-cache-hermes/tree/8088c19

Specifics:

• importHelpers is true
• target is es5
• downlevelIteration is true
• TypeScript version: 2.8.4 (~2.8.0)
• tslib version: 1.9.3 (^1.9.0)

Helpful reproduction repo built by @alexanderson1993 over in convoyinc/apollo-cache-hermes#382

When run on react-native android (and presumably older versions of Chrome), the following code infinite loops on tslib.__values (it emits undefined forever)

TypeScript source:

export class QueryInfo {
  // …
  public readonly variables: Set<string>;
  // …
  private _assertAllVariablesDeclared(messages: string[], declaredVariables: Set<string>) {
    for (const name of this.variables) {
      if (!declaredVariables.has(name)) {
        messages.push(`Variable $${name} is used, but not declared`);
      }
    }
  }
  // …
}

Emitted source:

// …
QueryInfo.prototype._assertAllVariablesDeclared = function (messages, declaredVariables) {
    try {
        for (var _a = tslib_1.__values(this.variables), _b = _a.next(); !_b.done; _b = _a.next()) {
            var name_1 = _b.value;
            if (!declaredVariables.has(name_1)) {
                messages.push("Variable $" + name_1 + " is used, but not declared");
            }
        }
    }
    catch (e_1_1) { e_1 = { error: e_1_1 }; }
    finally {
        try {
            if (_b && !_b.done && (_c = _a.return)) _c.call(_a);
        }
        finally { if (e_1) throw e_1.error; }
    }
    var e_1, _c;
};

// …

Observed: for (const name of this.variables) { loops forever, assigning undefined to name on each iteration

[nevir]

Other info:

• In this environment, Symbol.iterator is a string with value @@iterator
• o[Symbol.iterator] resolves to a function.
• typeof Symbol resolves to undefined. wtf? (Ah! it appears to be getting replaced during compilation by RN's packager…)

^ found by inserting the following line into __values:

throw new Error("typeof Symbol: " + typeof Symbol + ", typeof o[Symbol.iterator]: " + typeof o[Symbol.iterator]);

Output:

[nevir]

The root cause here appears to be a polyfill bug in RN's android environment, I think. Edit: yeah: Appears to be facebook/react-native#4676

However, I'm wondering if tslib should also handle this case a bit more gracefully?

[nevir]

Other info:

• In this environment, Symbol.iterator is a string with value @@iterator
• o[Symbol.iterator] resolves to a function.
• typeof Symbol resolves to undefined. wtf? (Ah! it appears to be getting replaced during compilation by RN's packager…)

^ found by inserting the following line into __values:

throw new Error("typeof Symbol: " + typeof Symbol + ", typeof o[Symbol.iterator]: " + typeof o[Symbol.iterator]);

Output:

[nevir]

The root cause here appears to be a polyfill bug in RN's android environment, I think. Edit: yeah: Appears to be facebook/react-native#4676

However, I'm wondering if tslib should also handle this case a bit more gracefully?