-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template based code renderer #15
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zhuorantan
commented
Jun 1, 2021
•
edited
Loading
edited
- Replace the existing code renderer with mustache template-based renderer.
- Refactor model typs
- Add OptionalType to replace nullable in ValueType
- Add DictionaryType to replace isAnyKeyDictionary in CustomType
- Rename all *TypeKind to *Type
- Parse named types after parsing
- Extract documentation instead of custom defined @comment JSDoc tag
- Add CodeGenerator class to handle the entire parsing and rendering process
- Add custom tags
- Add OptionalType to replace nullable in ValueType - Add DictionaryType to replace isAnyKeyDictionary in CustomType - Rename all *TypeKind to *Type - Remove all literalTypeDescription. It can be generated after parsing - Extract documentation instead of custom defined @comment JSDoc tag.
- Generate Swift API modules based on template - Support custom tags - Refactor enum representation
1b52593
to
2d8f31c
Compare
2d8f31c
to
ab17c1b
Compare
haven2world
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.