-
Notifications
You must be signed in to change notification settings - Fork 451
Add L-TAE model #2867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add L-TAE model #2867
Conversation
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Looks like the code is missing type hints throughout and needs to be formatted and limited with ruff! But otherwise lgtm.
Are there are any pretrained weights available for L-TAE?
Edit: also need to add the model to hubconf.py
and torchgeo/models/api.py
@MUYang99 any thoughts on just scrapping the custom implementations of MHA, SDPA, and positional embeddings with the implementations from the torch libraries? I think that torch has more optimized versions of MHA and SDPA. I think the LTAE code is just very old so the implementation didn't have these classes available in torch yet. |
Can you resolve the merge conflicts with |
Co-authored-by: Isaac Corley <22203655+isaaccorley@users.noreply.github.com>
Co-authored-by: Isaac Corley <22203655+isaaccorley@users.noreply.github.com>
Co-authored-by: Isaac Corley <22203655+isaaccorley@users.noreply.github.com>
Co-authored-by: Isaac Corley <22203655+isaaccorley@users.noreply.github.com>
Co-authored-by: Isaac Corley <22203655+isaaccorley@users.noreply.github.com>
Co-authored-by: Isaac Corley <22203655+isaaccorley@users.noreply.github.com>
Co-authored-by: Isaac Corley <22203655+isaaccorley@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to format with ruff format && ruff check
and fix mypy complaints and this is good to go!
Co-authored-by: Isaac Corley <22203655+isaaccorley@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lgtm @adamjstewart any final nits?
Add L-TAE model for satellite image time series processing: https://arxiv.org/pdf/2007.00586, https://github.com/VSainteuf/lightweight-temporal-attention-pytorch