Skip to content

Add L-TAE model #2867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Add L-TAE model #2867

wants to merge 26 commits into from

Conversation

MUYang99
Copy link

@MUYang99 MUYang99 commented Jul 2, 2025

@github-actions github-actions bot added documentation Improvements or additions to documentation models Models and pretrained weights testing Continuous integration testing labels Jul 2, 2025
@MUYang99
Copy link
Author

MUYang99 commented Jul 2, 2025

@microsoft-github-policy-service agree

Copy link
Collaborator

@isaaccorley isaaccorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks like the code is missing type hints throughout and needs to be formatted and limited with ruff! But otherwise lgtm.

Are there are any pretrained weights available for L-TAE?

Edit: also need to add the model to hubconf.py and torchgeo/models/api.py

@adamjstewart adamjstewart mentioned this pull request Jul 2, 2025
56 tasks
@adamjstewart adamjstewart added this to the 0.8.0 milestone Jul 2, 2025
@isaaccorley
Copy link
Collaborator

isaaccorley commented Jul 3, 2025

@MUYang99 any thoughts on just scrapping the custom implementations of MHA, SDPA, and positional embeddings with the implementations from the torch libraries?

I think that torch has more optimized versions of MHA and SDPA. I think the LTAE code is just very old so the implementation didn't have these classes available in torch yet.

@adamjstewart adamjstewart changed the title Add LTAE model Add L-TAE model Jul 12, 2025
@adamjstewart
Copy link
Collaborator

Can you resolve the merge conflicts with docs/api/models.rst? This will then allow the tests to run.

MUYang99 and others added 2 commits July 16, 2025 13:50
Co-authored-by: Isaac Corley <22203655+isaaccorley@users.noreply.github.com>
Co-authored-by: Isaac Corley <22203655+isaaccorley@users.noreply.github.com>
MUYang99 and others added 5 commits July 16, 2025 13:51
Co-authored-by: Isaac Corley <22203655+isaaccorley@users.noreply.github.com>
Co-authored-by: Isaac Corley <22203655+isaaccorley@users.noreply.github.com>
Co-authored-by: Isaac Corley <22203655+isaaccorley@users.noreply.github.com>
Co-authored-by: Isaac Corley <22203655+isaaccorley@users.noreply.github.com>
Co-authored-by: Isaac Corley <22203655+isaaccorley@users.noreply.github.com>
Copy link
Collaborator

@isaaccorley isaaccorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to format with ruff format && ruff check and fix mypy complaints and this is good to go!

Copy link
Collaborator

@isaaccorley isaaccorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm @adamjstewart any final nits?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation models Models and pretrained weights testing Continuous integration testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants