Support php 8.1 readonly property modifier RFC #357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TysonAndre
force-pushed
the
readonly-properties
branch
2 times, most recently
from
19ccec9 to
64be11a
Compare
roblourens
reviewed
Jul 16, 2021
roblourens
reviewed
Jul 16, 2021
| [] |
There was a problem hiding this comment.
Was all of this supposed to change?
There was a problem hiding this comment.
Yes, this is the new expected result. Previously, a lot of syntax errors resulted from the additional modifier when only a single modifier was allowed
<?php
class X {
// Starting in php 8.1, it is a compile error rather than a syntax error to have more than one visibility modifier
public function __construct(
public protected $var
) {}
}» php --version
PHP 8.1.0-dev (cli) (built: Jul 11 2021 12:15:15) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.0-dev, Copyright (c) Zend Technologies
with Zend OPcache v8.1.0-dev, Copyright (c), by Zend Technologies
» php tests/cases/parser/parameterPromotion2.php
Fatal error: Multiple access type modifiers are not allowed in /mnt/DATA/ifwe_programming/tolerant-php-parser/tests/cases/parser/parameterPromotion2.php on line 5
Supports https://wiki.php.net/rfc/first_class_callable_syntax It is possible that partial function application may allow mixing `...` with other arguments in the future, if that passes. See https://wiki.php.net/rfc/first_class_callable_syntax#syntax_choice So modify the argument instead of replacing the entire argument list with the token `...`
TysonAndre
force-pushed
the
readonly-properties
branch
from
64be11a to
190ebc0
Compare
TysonAndre
force-pushed
the
readonly-properties
branch
from
414ae57 to
78a7744
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wiki.php.net/rfc/readonly_properties_v2 is likely to pass