Support parsing new (call_function())()
#314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
reviewed
Feb 17, 2020
src/Parser.php
Outdated
| @@ -2822,19 +2822,37 @@ private function parseScopedPropertyAccessExpression($expression, $fallbackParen | |||
| return $scopedPropertyAccessExpression; | |||
| } | |||
|
|
|||
| public function isParsingObjectCreationExpression($expression) { | |||
There was a problem hiding this comment.
Is it typical in PHP to have a method and property with the same names? It threw me off.
And add tests for arbitrary parenthesized expressions in `new` and `instanceof`
TysonAndre
force-pushed
the
object-creation-parens
branch
from
3e3e221 to
c9fb699
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And add tests for arbitrary parenthesized expressions in
newandinstanceof