Fix a PHP notice generating a scoped property access expression #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And add a unit test
roblourens
reviewed
Sep 26, 2018
| $scopedPropertyAccessExpression->parent = $expression->parent ?? $fallbackParentNode; | ||
| if ($expression instanceof Node) { | ||
| $expression->parent = $scopedPropertyAccessExpression; | ||
| $scopedPropertyAccessExpression->scopeResolutionQualifier = $expression; // TODO ensure always a Node |
There was a problem hiding this comment.
Is the TODO now resolved, since it's in instanceof Node?
|
In the negation of the if statement, it's null (not a Node) - I wasn't completely sure what should be done there, so I left the (original) TODO as is for now. |
roblourens
approved these changes
Sep 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And add a unit test