Fixes #190: insteadof should be able to accept a name list
#243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do this in a way that makes it less likely that applications already using targetName will throw an exception or error. This should be revisited in a future backwards incompatible release. Add remainingTargetNames as a new property. NOTE: traits16.php is invalid php 7 code, so traits16.php.diag should be non-empty. However, tolerant-php-parser emits a slightly different error message than `php -l` would.
Add a test of parsing an empty `insteadof` clause Make remainingTargetNames consistently be an empty array instead of null
TysonAndre
force-pushed
the
fix-trait-list
branch
from
a48af3e to
797f795
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do this in a way that makes it less likely that applications already
using targetName will throw an exception or error.
This should be revisited in a future backwards incompatible release.
Add remainingTargetNames as a new property. (With the remainder of the tokens)
NOTE: traits16.php is invalid php 7 code,
so traits16.php.diag should be non-empty.
However, tolerant-php-parser emits a slightly different error
message than
php -lwould.