Skip to content

Incorrectly identified need for closing brace #267

Open

Description

@russjudge

Attached below is the code that was identified as needing a closing brace. The plug-in marked the end of the file as the point needing the brace

index.txt

Activity

  1. TysonAndre commented on Nov 28, 2018

    @TysonAndre
    Contributor

    This has a parse error in php 7.0 and 7.3

    Marking the syntax error to be the end of the file seems like the reasonable behavior (this typically emits errors where the MissingToken is). What do you expect the behavior to be?

    It might be user friendly to have additional information about the start as well, if that's what you meant.

    php -l index.txt
    
    Parse error: syntax error, unexpected end of file in index.txt on line 67
    Errors parsing index.txt
    
  2. sunverwerth commented on Nov 29, 2018

    @sunverwerth
    Contributor

    There is a short PHP Tag at the closing UL. I don't think tolerant PHP parser recognizes this as PHP code. Short tags are deprecated anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions