Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable internal testclass discovery #944
Enable internal testclass discovery #944
Changes from all commits
7a2e3b7File filter
Filter by extension
Conversations
Jump to
* Enable discovery of internal test classes It's useful to extract sets of test methods which establish some common criteria into reusable, generic, abstract test classes from which concrete test classes for specific types can be derived. However, this technique requires that the type under test be as accessible as the test class, itself. In particular, it's a compile-time error to have a public class derived from a generic class parameterized with an internal type. So, either the type must be made public or the test class must be made internal, in order for the compiler to be satisfied. Before the change in this PR, the test framework would only discover tests which were declared in public classes. This meant that the option of declaring the test class internal wasn't really an option at all: doing so would prevent the tests from running. So, types which should have been internal were marked public, just so they could be tested. The following code reiterates the dilemma. After this commit, the tests in the ```FancyStringsAreCaseInsensitive``` class will be discovered. FancyStringTets.cs ```C# using System; using DevProject1; using Microsoft.VisualStudio.TestTools.UnitTesting; namespace TestProject1 { [TestClass] public class FancyStringTests { [TestClass] // This class will not be discovered by MSTest because it is internal rather than public. // But, since FancyString is internal, marking the test class public will produce a compilation error. // This forces us to either make FancyString public or abandon this technique for reusing test classes. internal class FancyStringsAreCaseInsensitive : CaseInsensitivityTests<FancyString> { protected override Tuple<FancyString, FancyString> EquivalentInstancesWithDistinctCasing { get; } } } } ``` FancyString.cs ```C# using System; namespace DevProject1 { internal class FancyString { // TODO } } ``` CaseInsensitivityTests.cs ```C# using System; using Microsoft.VisualStudio.TestTools.UnitTesting; namespace TestProject1 { internal abstract class CaseInsensitivityTests<T> { protected abstract Tuple<T, T> EquivalentInstancesWithDistinctCasing { get; } [TestMethod] public void EqualityIsCaseInsensitive() { var (left, right) = EquivalentInstancesWithDistinctCasing; Assert.AreEqual(left, right); } [TestMethod] public void HashCodeIsCaseInsensitive() { // TODO } } } ``` * Add AnInternalTestClassDerivedFromAPublicAbstractGenericBaseClassForAnInternalTypeIsDiscovered This test establishes support for the principal motivating scenario for the discovery of internal test classes. * Add support for the discovery of internal test methods This commit renames DiscoverInternalTestClassesAttribute to DiscoverInternalsAttribute, and causes the presence of that attribute in the assembly to additionally discover test methods which are declared internal, in addition to test methods which are declared public. Co-authored-by: nohwnd <me@jakubjares.com> Co-authored-by: Medeni Baykal <433724+Haplois@users.noreply.github.com>There are no files selected for viewing