BugFix: WorkItemAttribute not extracted #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I'd really appreciate this PR. |
Haplois
suggested changes
Dec 5, 2020
|
Hello @Haplois! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Haplois
approved these changes
Dec 8, 2020
ghost
merged commit 
|
Thank you for your review! Is there any chance you could tell when a preview will be available? |
|
There is a back-compatibility issue in https://github.com/microsoft/vstest; after the fix is merged there, we can release a preview. Hopefully on this Friday, or mid next week at the latest. We're also continuously integrating into our daily feed. You can use that for now. The version should be "MSTest.TestAdapter 2.2.0-preview-20201209-01" after the build completes. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TypeEnumeratorclass returned anAttribute[], which cannot be casted to anWorkItemAttribute[]. Even though the method signature specified anAttribute[], the mock was set up to return aWorkItemAttribute[]array, which causes the test to pass but theasconversion to fail at runtime.