Introduce non-generic AcceptanceTestBase and move static members to it #7369
+83
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
approved these changes
Feb 9, 2026
Member
Evangelink
left a comment
Evangelink
left a comment
There was a problem hiding this comment.
Ooooh I never paid attention it was suppressed!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The static constructor of
AcceptanceTestBase<T>is invoked for every generic argument, while the logic there is mostly static and needs to be invoked only once. Moving all static members to a base non-generic class reduces the number of times we call the static constructor, and also follows CA1000.