Report the actual exception from assertion #6989
Open
+37
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
reviewed
Nov 26, 2025
| typeof(TException), | ||
| ex.GetType()); | ||
| ex.GetType(), | ||
| ex.ToString()); |
Member
There was a problem hiding this comment.
ex.ToString() already contains the type right? Should we just have ex.ToString() to avoid unnecessarily duplicate info in assertion failure message?
Member
Author
There was a problem hiding this comment.
I considered it but the whole message needs more love (I am summarizing that in the linked issue). So let's consider this just the first step there to help investigating the issue you were seeing.
Member
There was a problem hiding this comment.
The issue I was seeing is already fixed, it was just the message update related to caller arg expression breaking the test.
Youssef1313
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fix #6906
The data are there, but the formatting is not great.