Add FSharp E2E test #683
Merged
Add FSharp E2E test #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you made the PR from master, it is better if you make the PR from a different branch (a so called topic branch or feature branch). PR is just a pointer to a branch, and so anything that you'd do in your master would be reflected here. But it is okay for now as long as you only do fix for this in your master :) |
|
Thanks @nohwnd, I'm familiar with this, just really sloppy 😄I don't intend on doing any other work on testfx. I did make a start on this, but I lost steam and it's slipped in my priorities, so feel free to assume I won't be doing anything with this for at least a month. |
|
@slang25 finished it. waits for review, don't touch your master branch just yet 😁 |
cvpoienaru
reviewed
Mar 19, 2020
src/Adapter/MSTest.CoreAdapter/Extensions/TestCaseExtensions.cs
Outdated
Show resolved
Hide resolved
src/Adapter/MSTest.CoreAdapter/Extensions/TestCaseExtensions.cs
Outdated
Show resolved
Hide resolved
|
Nice one @nohwnd 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial failing test to aid with #682