Skip to content

Cleanup Dispose implementations #6730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2025
Merged

Cleanup Dispose implementations #6730

merged 1 commit into from
Oct 13, 2025

Conversation

@Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Oct 12, 2025 •
edited
Loading

  • Implementing IAsyncDisposable without IDisposable doesn't look like a good pattern. I changed those to always implement IDisposable, and then implement IAsyncDisposable when on .NET (Core)
  • Cleaned up unnecessary DisposeAsync of NamedPipeClient.
  • Cleaned up unnecessary calls of PipeNameDescription.Dispose.

@Youssef1313 Youssef1313 force-pushed the dev/ygerges/cleanup-dispose branch 2 times, most recently from 907d792 to 8b8fd65 Compare October 12, 2025 08:10
@Youssef1313 Youssef1313 force-pushed the dev/ygerges/cleanup-dispose branch from 8b8fd65 to 3414d2d Compare October 12, 2025 08:21
@Youssef1313 Youssef1313 merged commit 5244303 into main Oct 13, 2025
8 checks passed
@Youssef1313 Youssef1313 deleted the dev/ygerges/cleanup-dispose branch October 13, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nohwnd nohwnd nohwnd approved these changes

@engyebrahim engyebrahim Awaiting requested review from engyebrahim

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Youssef1313 @nohwnd