Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs in parent class init/cleanup logic #660

Merged
merged 6 commits into from
Dec 20, 2019
Merged

Fix bugs in parent class init/cleanup logic #660

merged 6 commits into from
Dec 20, 2019

Commits on Nov 19, 2019

  1. Adding UT to catch issue where base class cleanup isn't called if not… 

    … class cleanup on top level class
    @NGloreous
    NGloreous committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    7158165 View commit details
    Browse the repository at this point in the history

  2. Fixing test

    @NGloreous
    NGloreous committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    e46cdf0 View commit details
    Browse the repository at this point in the history

  3. Fix issue where base class cleanup isn't called when there is no top … 

    …level class cleanup
    @NGloreous
    NGloreous committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    60ca008 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2019

  1. Add test to catch null ref ex when grandparent test class has class i… 

    …nit/cleanup methods
    @NGloreous
    NGloreous committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    40e6fa9 View commit details
    Browse the repository at this point in the history

  2. Fix null ref ex when grandparent test class has class init/cleanup me… 

    …thods
    @NGloreous
    NGloreous committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    e4e01f4 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2019

  1. Addressing PR feedback

    @NGloreous
    NGloreous committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    8002eda View commit details
    Browse the repository at this point in the history