Avoid IVT between test framework and adapter #5628
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
force-pushed
the
dev/ygerges/avoid-ivt
branch
from
cf2acf6 to
d5fb5cd
Compare
|
@nohwnd This is cascading for too many APIs other than the ones we discussed 😕 |
|
might not be worth it to go this way? :/ |
|
@nohwnd Yeah I think so. |
|
Closing for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on:
ReflectionTestMethodInfois internal and needed both in TestFramework and TestAdapter. There is a design flaw here IMO that can be improved.TestIdGenerationStrategyisprotected internaland is set by TestAdapter.