Skip to content

Add implicit using even when not using MSTest.Sdk #5589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Youssef1313
Copy link
Member

No description provided.

Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You moved it only under winui+uwp targets

@Youssef1313
Copy link
Member Author

You moved it only under winui+uwp targets

I thought it's just a naming issue on our side and the same file is used for everything, as we seem to include it for all TFMs in nuspec, for example:

<file src="net7.0\buildTransitive\winui+uwp\MSTest.TestFramework.targets" target="buildTransitive\net7.0\" />

But there are test failures so there is an issue with my change. I'll spend some time to hunt it down.

@Evangelink
Copy link
Member

My bad! There was some refactoring and there is a single targets left (would be good to cleanup the name).

@Evangelink
Copy link
Member

I have not followed all changes but the buildTransitive is not defined for all supported TFMs which is likely causing the issue above:

image

@Evangelink Evangelink self-requested a review May 20, 2025 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants