Base class data rows should not be executed #546
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT license. See LICENSE file in the project root for full license information. | ||
|
|
||
| namespace MSTestAdapter.Smoke.E2ETests | ||
| { | ||
| using Microsoft.MSTestV2.CLIAutomation; | ||
| using Microsoft.VisualStudio.TestTools.UnitTesting; | ||
|
|
||
| [TestClass] | ||
| public class DataRowTests : CLITestBase | ||
| { | ||
| private const string TestAssembly = "DataRowTestProject.dll"; | ||
|
|
||
| [TestMethod] | ||
| public void ExecuteOnlyDerivedClassDataRowsWhenBothBaseAndDerviedClassHasDataRows() | ||
| { | ||
| this.InvokeVsTestForExecution(new string[] { TestAssembly }); | ||
|
|
||
| this.ValidatePassedTestsContain( | ||
|
There was a problem hiding this comment. Shouldn't this validation change after using the filter ? There was a problem hiding this comment. By mistake added filter in first test. |
||
| "DataRowTestMethod (BaseString1)", | ||
| "DataRowTestMethod (BaseString2)", | ||
| "DataRowTestMethod (BaseString3)", | ||
| "DataRowTestMethod (DerivedString1)", | ||
| "DataRowTestMethod (DerivedString2)"); | ||
|
|
||
| // 4 tests of BaseClass - 3 datarow result and 1 parent result | ||
| // 3 tests of DerivedClass - 2 datarow result and 1 parent result | ||
| // Total 7 tests - Making sure that DerivedClass doesn't run BaseClass tests | ||
| this.ValidatePassedTestsCount(7); | ||
|
There was a problem hiding this comment. This is little confusing. There was a problem hiding this comment. Didn't realize the confusion. Added new test. |
||
| } | ||
|
|
||
| [TestMethod] | ||
| public void ExecuteOnlyDerivedClassDataRowsWhenItOverridesBaseClassDataRows() | ||
| { | ||
| this.InvokeVsTestForExecution(new string[] { TestAssembly }, testCaseFilter: "FullyQualifiedName~DerivedClass"); | ||
|
|
||
| this.ValidatePassedTestsContain( | ||
| "DataRowTestMethod (DerivedString1)", | ||
| "DataRowTestMethod (DerivedString2)"); | ||
|
|
||
| // 3 tests of DerivedClass - 2 datarow result and 1 parent result | ||
| this.ValidatePassedTestsCount(3); | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT license. See LICENSE file in the project root for full license information. | ||
|
|
||
| namespace DataRowTestProject | ||
| { | ||
| using Microsoft.VisualStudio.TestTools.UnitTesting; | ||
|
|
||
| [TestClass] | ||
| public class BaseClass | ||
| { | ||
| [TestMethod] | ||
| [DataRow("BaseString1")] | ||
| [DataRow("BaseString2")] | ||
| [DataRow("BaseString3")] | ||
| public virtual void DataRowTestMethod(string a) | ||
| { | ||
| Assert.IsTrue(true); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <TestFxRoot Condition="$(TestFxRoot) == ''">..\..\..\..\</TestFxRoot> | ||
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>net452</TargetFramework> | ||
| <IsPackable>false</IsPackable> | ||
| <AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath> | ||
| <OutputPath>$(TestFxRoot)artifacts\TestAssets\</OutputPath> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="..\..\..\..\src\TestFramework\Extension.Desktop\Extension.Desktop.csproj" /> | ||
| <ProjectReference Include="..\..\..\..\src\TestFramework\MSTest.Core\MSTest.Core.csproj" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <Service Include="{82a7f48d-3b50-4b1e-b82e-3ada8210c358}" /> | ||
| </ItemGroup> | ||
|
|
||
| </Project> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT license. See LICENSE file in the project root for full license information. | ||
|
|
||
| namespace DataRowTestProject | ||
| { | ||
| using Microsoft.VisualStudio.TestTools.UnitTesting; | ||
|
|
||
| [TestClass] | ||
| public class DerivedClass : BaseClass | ||
| { | ||
| [TestMethod] | ||
| [DataRow("DerivedString1")] | ||
| [DataRow("DerivedString2")] | ||
| public override void DataRowTestMethod(string a) | ||
| { | ||
| Assert.IsTrue(true); | ||
| } | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.