-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow async test methods for UITestMethod on UWP and WinUI #5297
Conversation
Uhm, how does this address #740? The former is about being able to use datarows with UITests, this PR on the other hand allows using async on tests right? |
@marcelwgn The original issue description is inaccurate. Based on the comments/discussions there, the real issue is really just UITestMethodAttribute deadlocking. Using parameterized tests does not require DataTestMethodAttribute, and so we should not introduce UIDataTestMethodAttribute as it doesn't serve any purpose. |
So the following test should work then?
Because when I run it in Visual Studio, I get the following issue:
The thread in that issue evolved to providing a workaround to that missing capability using async tests that would essentially implement the behaviour that UITestMethod should support, but that requires async which is not supported. I disagree that the original issue description is misleading, the above sample does not work so there still is no support for this. ALlowing async would just allow for a workaround to work. |
It's supposed to work. I'll check why it doesn't work, but that wasn't what I understood from the follow-up comments. |
@marcelwgn This should be working if you are using the latest MSTest. I could repro only with really old versions of MSTest that are not supported. |
Fixes #5306