-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic data display name #373
Changes from 6 commits
b7efb25
09c30cf
0b428fd
11011dc
b2bb90e
13c83c5
d0af564
80192b8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -283,4 +283,7 @@ Stack Trace: {4}</value> | |
<data name="DynamicDataValueNull" xml:space="preserve"> | ||
<value>Value returned by property or method {0} shouldn't be null.</value> | ||
</data> | ||
<data name="DynamicDataDisplayName" xml:space="preserve"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also please run "build.cmd -uxlf" so the string addition is localizable. You would have to commit the xlf files changes post running the script. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I ran this and have committed the xlf files. I'm assuming someone or some magic will do the translation? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes please. We just needed modified xlf files. We will take care of the translation 😄 |
||
<value>Method {0} must match the expected signature: public static {1} {0}({2}).</value> | ||
</data> | ||
</root> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bstoney : Method signature should also have "public" access modifier specified. Can you please add that as well??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will have to update xlf files as well if you modify FrameworkMessages.DynamicDataDisplayName string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Interestingly it did work with a private static method even though the documentation for
GetDeclaredMethod
states that "Returns an object that represents the specified public method declared by the current type." I have updated the exception message and added a test for public accessibility.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super 👍